[prev in list] [next in list] [prev in thread] [next in thread] 

List:       ethereal-cvs
Subject:    [Ethereal-cvs] cvs commit: ethereal cfile.h file.c file.h
From:       Guy Harris <guy () thud ! ethereal ! com>
Date:       2003-08-29 4:03:46
[Download RAW message or body]

guy         2003/08/28 23:03:46 CDT

  Modified files:
    .                    cfile.h file.c file.h 
  Log:
  Get rid of the EBCDIC stuff in the find dialog - it's not supported yet,
  so we shouldn't torment the users by offering it.
  
  Check the string type and convert it to an internal representation in
  the GUI code; have the search code deal only with the internal
  representation.
  
  Save the case-sensitivity flag, and the indication of where string
  searches look, along with other search parameters.
  
  Upper-casify the string, for case-insensitive searches, in the GUI code;
  don't save the upper-casified string, so it doesn't SHOUT at you when
  you next pop up a "find" dialog.
  
  Convert the hex value string to raw binary data in the GUI code, rather
  than doing so in the search code.  Check that it's a valid string.
  
  Connect the signals to the radio buttons after the pointers have been
  attached to various GUI items - the signal handlers expect some of those
  pointers to be attached, and aren't happy if they're not.
  
  Have "find_packet()" contain a framework for searching, but not contain
  the matching code; instead, pass it a pointer to a matching routine and
  an opaque pointer to be passed to the matching routine.  Have all the
  routines that do different types of searching have their own matching
  routines, and use the common "find_packet()" code, rather than
  duplicating that code.
  
  Search for the Info column by column type, not by name (the user can
  change the name).
  
  When matching on the protocol tree, don't format the entire protocol
  tree into a big buffer - just have a routine that matches the text
  representation of a protocol tree item against a string, and, if it
  finds a match, sets a "we found a match flag" and returns; have that
  routine not bother doing any more work if that flag is set.
  (Unfortunately, you can't abort "g_node_children_foreach()" in the
  middle of a traversal.)
  
  Free the generated display filter code after a find-by-display-filter
  finishes.
  
  Revision  Changes    Path
  1.3       +16 -5     ethereal/cfile.h
  1.304     +311 -508  ethereal/file.c
  1.104     +8 -2      ethereal/file.h

_______________________________________________
Ethereal-cvs mailing list
Ethereal-cvs@ethereal.com
http://www.ethereal.com/mailman/listinfo/ethereal-cvs
[prev in list] [next in list] [prev in thread] [next in thread]