[prev in list] [next in list] [prev in thread] [next in thread] 

List:       esb-java-dev
Subject:    Re: [Dev] Improving MB Slot Coordinator to Work in a NATed/Containerized Environment
From:       Isuru Haththotuwa <isuruh () wso2 ! com>
Date:       2016-08-31 13:59:43
Message-ID: CAC4qKNZ41KbCYf5df0=vU8zSNrmSdBESbhK8_=yrg7A2wpm12A () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi Imesh and Ramith,

Replied to your comments in the original PR, please check.

On Tue, Aug 30, 2016 at 7:58 PM, Isuru Haththotuwa <isuruh@wso2.com> wrote:

> Hi Hasitha,
>
> Please find the PR for adding the new properties to the broker.xml file
> [1].
>
> [1]. https://github.com/wso2/carbon-business-messaging/pull/336
>
> On Sun, Aug 28, 2016 at 8:23 PM, Isuru Haththotuwa <isuruh@wso2.com>
> wrote:
>
>> Hi Hasitha,
>>
>> On Sun,  Aug 28, 2016 at 7:30 AM, Hasitha Hiranya <hasithah@wso2.com>
>> wrote:
>>
>>> Hi,
>>>
>>> Thank You, Isuru...!!
>>>
>>> If you add a new property to broker.xml config file, that file needs a
>>> update as well. So broker.xml of carbon-business-messaging [1] has to be
>>> changed I guess. Please add a proper description to the property in the
>>> file for the parameter you are adding.
>>>
>> Thanks, will do and send a PR.
>>
>>>
>>> [1]. https://github.com/wso2/carbon-business-messaging/blob/
>>> master/features/andes/org.wso2.carbon.andes.server.feature/
>>> resources/conf/broker.xml
>>>
>>> Thanks
>>>
>>> On Fri, Aug 26, 2016 at 8:15 PM, Imesh Gunaratne <imesh@wso2.com> wrote:
>>>
>>>> [+ Ramith]
>>>>
>>>> Great work Isuru!! Well written!!
>>>> I think it might be useful for explaining why this feature was needed
>>>> in the PR description.
>>>>
>>>> Thanks!
>>>>
>>>> On Fri, Aug 26, 2016 at 5:37 PM, Isuru Haththotuwa <isuruh@wso2.com>
>>>> wrote:
>>>>
>>>>> Hi MB team,
>>>>>
>>>>> Please review the P/R for $subject [1], for the jira ticket reported
>>>>> at [2]. I'm yet to write a test for this, will send a separate P/R once
>>>>> done.
>>>>>
>>>>> [1]. https://github.com/wso2/andes/pull/685
>>>>>
>>>>> [2]. https://wso2.org/jira/browse/MB-1736
>>>>>
>>>>>
>>>>> --
>>>>> Thanks and Regards,
>>>>>
>>>>> Isuru H.
>>>>> +94 716 358 048
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Dev mailing list
>>>>> Dev@wso2.org
>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> *Imesh Gunaratne*
>>>> Software Architect
>>>> WSO2 Inc: http://wso2.com
>>>> T: +94 11 214 5345 M: +94 77 374 2057
>>>> W: https://medium.com/@imesh TW: @imesh
>>>> lean. enterprise. middleware
>>>>
>>>>
>>>> _______________________________________________
>>>> Dev mailing list
>>>> Dev@wso2.org
>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>>
>>>>
>>>
>>>
>>> --
>>> *Hasitha Abeykoon*
>>> Senior Software Engineer; WSO2, Inc.; http://wso2.com
>>> *cell:* *+94 719363063*
>>> *blog: **abeykoon.blogspot.com* <http://abeykoon.blogspot.com>
>>>
>>>
>>
>>
>> --
>> Thanks and Regards,
>>
>> Isuru H.
>> +94 716 358 048* <http://wso2.com/>*
>>
>>
>>
>
>
> --
> Thanks and Regards,
>
> Isuru H.
> +94 716 358 048* <http://wso2.com/>*
>
>
>


-- 
Thanks and Regards,

Isuru H.
+94 716 358 048* <http://wso2.com/>*

[Attachment #5 (text/html)]

<div dir="ltr"><div>Hi Imesh and Ramith, <br><br></div><div>Replied to your comments \
in the original PR, please check.<br></div></div><div class="gmail_extra"><br><div \
class="gmail_quote">On Tue, Aug 30, 2016 at 7:58 PM, Isuru Haththotuwa <span \
dir="ltr">&lt;<a href="mailto:isuruh@wso2.com" \
target="_blank">isuruh@wso2.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><div>Hi Hasitha, <br><br></div>Please find the \
PR for adding the new properties to the broker.xml file [1].<br><br>[1]. <a \
href="https://github.com/wso2/carbon-business-messaging/pull/336" \
target="_blank">https://github.com/wso2/<wbr>carbon-business-messaging/<wbr>pull/336</a><br></div><div \
class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div \
class="gmail_quote">On Sun, Aug 28, 2016 at 8:23 PM, Isuru Haththotuwa <span \
dir="ltr">&lt;<a href="mailto:isuruh@wso2.com" \
target="_blank">isuruh@wso2.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr">Hi Hasitha, <br><div><div \
class="gmail_extra"><br><div class="gmail_quote"><span>On Sun,   Aug 28, 2016 at 7:30 \
AM, Hasitha Hiranya <span dir="ltr">&lt;<a href="mailto:hasithah@wso2.com" \
target="_blank">hasithah@wso2.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr">Hi,<div><br></div><div>Thank You, Isuru...!!  \
</div><div><br></div><div>If you add a new property to broker.xml config file, that \
file needs a update as well. So broker.xml of carbon-business-messaging [1] has to be \
changed I guess. Please add a proper description to the property in the file for the \
parameter you are adding.  </div></div></blockquote></span><div>Thanks, will do and \
send a PR. <br></div><div><div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex"><div \
dir="ltr"><div><br></div><div>[1].  <a \
href="https://github.com/wso2/carbon-business-messaging/blob/master/features/andes/org.wso2.carbon.andes.server.feature/resources/conf/broker.xml" \
target="_blank">https://github.com/wso2/c<wbr>arbon-business-messaging/blob/<wbr>maste \
r/features/andes/org.wso2<wbr>.carbon.andes.server.feature/<wbr>resources/conf/broker.xml</a></div><div><br></div><div>Thanks</div></div><div \
class="gmail_extra"><br><div class="gmail_quote"><span>On Fri, Aug 26, 2016 at 8:15 \
PM, Imesh Gunaratne <span dir="ltr">&lt;<a href="mailto:imesh@wso2.com" \
target="_blank">imesh@wso2.com</a>&gt;</span> wrote:<br></span><div><div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><div \
style="font-family:arial,helvetica,sans-serif"><div>[+ \
Ramith]</div><div><br></div><div>Great work Isuru!! Well written!!</div><div>I think \
it might be useful for explaining why this feature was needed in the PR description.  \
</div><div><br></div><div>Thanks!</div></div></div><div class="gmail_extra"><br><div \
class="gmail_quote"><div><div>On Fri, Aug 26, 2016 at 5:37 PM, Isuru Haththotuwa \
<span dir="ltr">&lt;<a href="mailto:isuruh@wso2.com" \
target="_blank">isuruh@wso2.com</a>&gt;</span> wrote:<br></div></div><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div><div><div dir="ltr"><div><div>Hi MB team, \
<br><br></div>Please review the P/R for $subject [1], for the jira ticket reported at \
[2]. I&#39;m yet to write a test for this, will send a separate P/R once \
done.<br><br>[1]. <a href="https://github.com/wso2/andes/pull/685" \
target="_blank">https://github.com/wso2/andes/<wbr>pull/685</a><br><br>[2]. <a \
href="https://wso2.org/jira/browse/MB-1736" \
target="_blank">https://wso2.org/jira/browse/M<wbr>B-1736</a> <br><span><font \
color="#888888"><br><br>-- <br><div data-smartmail="gmail_signature"><div \
dir="ltr"><div>Thanks and Regards,<br><br>Isuru H.<br></div><div> <a \
href="tel:%2B94%20716%20358%20048" value="+94716358048" target="_blank">+94 716 358 \
048</a><br><br><br></div></div></div> </font></span></div></div>
<br></div></div>______________________________<wbr>_________________<br>
Dev mailing list<br>
<a href="mailto:Dev@wso2.org" target="_blank">Dev@wso2.org</a><br>
<a href="http://wso2.org/cgi-bin/mailman/listinfo/dev" rel="noreferrer" \
target="_blank">http://wso2.org/cgi-bin/mailma<wbr>n/listinfo/dev</a><br> \
<br></blockquote></div><span><font color="#888888"><br><br \
clear="all"><div><br></div>-- <br><div data-smartmail="gmail_signature"><div \
dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div \
dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div><div \
dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><span \
style="color:rgb(153,153,153)"></span><b>Imesh Gunaratne</b><br><font color="#666666" \
size="2">Software Architect<br>WSO2 Inc: <a href="http://wso2.com" \
target="_blank">http://wso2.com</a><br>T: +94 11 214 5345 <span \
style="font-family:arial,sans-serif"></span><span \
style="font-family:arial,sans-serif"></span>M: <a href="tel:%2B94%2077%20374%202057" \
value="+94773742057" target="_blank">+94 77 374 2057</a><br>W: <a \
href="https://medium.com/@imesh" target="_blank">https://medium.com/@imesh</a> TW: \
@imesh  </font></div><div dir="ltr"><span style="font-size:12.8px"><font \
color="#666666">lean. enterprise. middleware</font></span><font color="#666666" \
size="2"><br></font><br></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div></div>
 </font></span></div>
<br>______________________________<wbr>_________________<br>
Dev mailing list<br>
<a href="mailto:Dev@wso2.org" target="_blank">Dev@wso2.org</a><br>
<a href="http://wso2.org/cgi-bin/mailman/listinfo/dev" rel="noreferrer" \
target="_blank">http://wso2.org/cgi-bin/mailma<wbr>n/listinfo/dev</a><br> \
<br></blockquote></div></div></div><span><font color="#888888"><br><br \
clear="all"><div><br></div>-- <br><div data-smartmail="gmail_signature"><div \
dir="ltr"><font face="courier new, monospace"><b>Hasitha \
Abeykoon</b><br></font><div><font face="courier new, monospace"><span><span \
style="font-size:x-small">Senior Software Engineer</span>;  <span \
style="font-size:x-small">WSO2, Inc.;</span></span><span><span \
style="font-size:x-small">  </span><span \
style="color:rgb(17,85,204);font-size:x-small"><a href="http://wso2.com/" \
style="color:rgb(17,85,204)" \
target="_blank">http://wso2.com</a></span></span></font></div><div><font \
face="courier new, monospace"><span><i><span \
style="font-size:x-small">cell:</span></i></span><span>  </span><span><i><span \
style="font-size:x-small"><a value="+94773320919" style="color:rgb(17,85,204)">+94 \
719363063</a></span></i></span></font></div><div><font face="courier new, \
monospace"><span><i><span style="font-size:x-small">blog:  </span></i></span><span><a \
href="http://abeykoon.blogspot.com" style="color:rgb(17,85,204)" \
target="_blank"><i><span \
style="font-size:x-small">abeykoon.blogspot.com</span></i></a></span><span><i><span \
style="font-size:x-small">  \
</span></i></span></font></div><div><span><i><br></i></span></div></div></div> \
</font></span></div> </blockquote></div></div></div><div><div><br><br \
clear="all"><br>-- <br><div data-smartmail="gmail_signature"><div \
dir="ltr"><div>Thanks and Regards,<br><br>Isuru H.<br></div><div> <a \
href="tel:%2B94%20716%20358%20048" value="+94716358048" target="_blank">+94 716 358 \
048</a><i><a href="http://wso2.com/" \
target="_blank"></a></i><br><br><br></div></div></div> </div></div></div></div></div>
</blockquote></div><br><br clear="all"><br>-- <br><div \
data-smartmail="gmail_signature"><div dir="ltr"><div>Thanks and Regards,<br><br>Isuru \
H.<br></div><div> <a href="tel:%2B94%20716%20358%20048" value="+94716358048" \
target="_blank">+94 716 358 048</a><i><a href="http://wso2.com/" \
target="_blank"></a></i><br><br><br></div></div></div> </div>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><div \
class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div>Thanks \
and Regards,<br><br>Isuru H.<br></div><div> +94 716 358 048<i><a \
href="http://wso2.com/" target="_blank"></a></i><br><br><br></div></div></div> </div>



_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic