[prev in list] [next in list] [prev in thread] [next in thread] 

List:       enlightenment-devel
Subject:    Re: [E-devel] ephoto bug
From:       "Rbt. Y-Lee" <ylee () bodhilinux ! com>
Date:       2021-10-06 19:58:32
Message-ID: CAP8uWWyfQZ9G+wk_aaX=yqhR-g=3D-_ML2fO7GH8Z5ynoD1bFg () mail ! gmail ! com
[Download RAW message or body]

A test on tb (or object) in the right circumstance segfaults elsewhere plus
regardless it leaves the cursor messed up
as elm_object_cursor_unset(tb->main); is not executed.

https://pastebin.com/agXAybrA

 _drop_dropcb (data=0x0, obj=0x40000003182c, it=0x0,
    ev=0x7fffffffc7e0, xposret=0, yposret=0)
    at ../src/bin/ephoto_thumb_browser.c:161

I can change the code around some and get ephoto to not segfault as well as
not leave the cursor messed up BUT the DND an image to say a folder does
not work. Clearly I am not understanding something or EFL is not 'acting
right.'

What I am thinking based on the documentation is that the function
_dnd_drag_done(void *data, Evas_Object *obj,  Eina_Bool doaccept
EINA_UNUSED)
should have the form :

void(* Elm_Drag_State) (void *data, Evas_Object *obj)
Callback called when a drag is finished, enters, or leaves an object.

Parameters
data    Application specific data
obj    The object where the drag started

And the object where the drag started should be  Ephoto_Thumb_Browser *tb
it is in the rest of those DND callbacks.

Documentation:
https://docs.enlightenment.org/stable/elementary/group__CopyPaste.html

I may be confused tho as the documentation is not clear to me and I lack
any good examples that illustrate what okra was trying to do here.

All I can find is this
https://www.enlightenment.org/develop/efl/advanced/dnd.



On Wed, Oct 6, 2021 at 2:56 PM Vincent Torri <vincent.torri@gmail.com>
wrote:

> On Wed, Oct 6, 2021 at 6:50 PM Rbt. Y-Lee <ylee@bodhilinux.com> wrote:
> >
> > I know ephoto seems unmaintained but a Bodhi Linux user reported an
> > ephoto Drag and Drop bug to me. A video he created illustrates the
> issue. I
> > am hoping someone can look at this...
> >
> > Here is a backtrace using efl and ehoto in e-git (briefly the bug is
> caused
> > by in this user case obj passed to  _dnd_drag_done  in
> > /src/bin/ephoto_thumb_browser.c:283 is NULL):
> >
> > Backtrace: https://pastebin.com/hcsZETD9
>
> test on tb is necessary
>
> Vincent
>
>
> >
> > code/efl$ git show
> > commit 57a5655f889a293adb11db09a4f35378aa29a9bb (HEAD -> master,
> > origin/master, origin/HEAD)
> > Author: Christopher Michael <devilhorns@comcast.net>
> > Date:   Tue Oct 5 10:27:45 2021 -0400
> >
> >     exactness: Fix compiler warning of uninitialized variable
> >
> >     Compiler is warning us here that ex_img has not been initialized
> after
> >     being malloc'd, so let's initialize it
> > _______________________________________________
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>
>
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
>

_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[prev in list] [next in list] [prev in thread] [next in thread]