[prev in list] [next in list] [prev in thread] [next in thread] 

List:       enlightenment-devel
Subject:    Re: [E-devel] [EGIT] [core/efl] master 01/01: eina_tiler: fix typo of rect comparing
From:       Carsten Haitzler (The Rasterman) <raster () rasterman ! com>
Date:       2018-02-06 11:19:22
Message-ID: 20180206201922.a20dae3858d12fbf50973c6f () rasterman ! com
[Download RAW message or body]

On Mon, 05 Feb 2018 14:56:14 +0000 Mike Blumenkrantz
<michael.blumenkrantz@gmail.com> said:

> This looks like an obvious typo
> from f18d9d7237b6415735d0faae27ab817732047265, nicely found. Is this in the
> Coverity issues list? It seems like something which should show up there

i don't ever remember seeing this in coverity and i got the issues pretty low
last release cycle. if this has been there i'd have fixed it as it would have
been trivial.

> On Mon, Feb 5, 2018 at 6:29 AM Shinwoo Kim <cinoo.kim@samsung.com> wrote:
> 
> > kimcinoo pushed a commit to branch master.
> >
> >
> > http://git.enlightenment.org/core/efl.git/commit/?id=bb5f4aa857e5fbc1cb067317e690fcc5aae40a24
> >
> > commit bb5f4aa857e5fbc1cb067317e690fcc5aae40a24
> > Author: Shinwoo Kim <cinoo.kim@samsung.com>
> > Date:   Mon Feb 5 20:02:06 2018 +0900
> >
> >     eina_tiler: fix typo of rect comparing
> > ---
> >  src/lib/eina/eina_tiler.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/lib/eina/eina_tiler.c b/src/lib/eina/eina_tiler.c
> > index 7597d1e286..e8ea2eb858 100644
> > --- a/src/lib/eina/eina_tiler.c
> > +++ b/src/lib/eina/eina_tiler.c
> > @@ -1216,7 +1216,7 @@ _rect_same(Eina_Rectangle *rec1, Eina_Rectangle
> > *rec2)
> >     // this is ok because all the rects being compared will be aligned to
> > 8bytes
> >     Rectangle_Same *same1 = (Rectangle_Same *)rec1;
> >     Rectangle_Same *same2 = (Rectangle_Same *)rec2;
> > -   return ((same1->x == same2->y) && (same1->y == same2->y));
> > +   return ((same1->x == same2->x) && (same1->y == same2->y));
> >  }
> >
> >  EAPI Eina_Bool eina_tiler_rect_add(Eina_Tiler *t, const Eina_Rectangle *r)
> >
> > --
> >
> >
> >
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> enlightenment-devel mailing list
> enlightenment-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> 


-- 
------------- Codito, ergo sum - "I code, therefore I am" --------------
Carsten Haitzler - raster@rasterman.com


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[prev in list] [next in list] [prev in thread] [next in thread]