[prev in list] [next in list] [prev in thread] [next in thread] 

List:       enlightenment-devel
Subject:    Re: [E-devel] [EGIT] [core/efl] master 02/03: efl: Use Eina.Position2D for Efl.Gfx.position
From:       Jean-Philippe_André <jpeg () videolan ! org>
Date:       2017-09-19 1:56:02
Message-ID: CAGzBKWNy2akgr9w4_7VBq39KLnr-d3iFoXKYeyERzZiDB8WEOQ () mail ! gmail ! com
[Download RAW message or body]

Hi,

2017-09-19 5:12 GMT+09:00 Gustavo Sverzut Barbieri <barbieri@gmail.com>:

> On Mon, Sep 18, 2017 at 1:41 AM, Jean-Philippe ANDRÉ <jpeg@videolan.org>
> wrote:
>
> > +        efl_input_pointer_position_set(td->evmove, r.x, r.y);
> > +        efl_input_pointer_position_set(td->evdown, r.x, r.y);
> > +        efl_input_pointer_position_set(td->evup, r.x, r.y);
>
> I'd expect efl_input_pointer_position_set(td->evup, r)
>
> why not?
>

This needs a position, not a rect.


> As for here:
>
> > +        pos = efl_gfx_position_get(o);
> > +        pos.x += (x - fd->x);
> > +        pos.y += (y - fd->y);
> > +        efl_gfx_position_set(o, pos);
>
> I'd expect:
>
>     pos = efl_gfx_position_get(o);
>     pos = eina_position2d_move(pos, x - fd->x, y->fd->y);
>     efl_gfx_position_set(o, pos);
>

Yes, those helpers can be added.

note: I just skimmed over the patch, didn't look every single line.
> <https://lists.sourceforge.net/lists/listinfo/enlightenment-devel>


This is work in progress. Patch after patch I'm covering more APIs with
Size, Position and Rect. There's "alot" of them.

-- 
Jean-Philippe André
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel

[prev in list] [next in list] [prev in thread] [next in thread]