[prev in list] [next in list] [prev in thread] [next in thread] 

List:       enlightenment-devel
Subject:    Re: [E-devel] [EGIT] [core/efl] master 01/02: Tests: fix remote image
From:       Daniel Zaoui <jackdanielz () eyomi ! org>
Date:       2017-09-16 18:35:35
Message-ID: 20170916213535.56bc1e99 () Yoga
[Download RAW message or body]

On Sat, 16 Sep 2017 11:27:25 +0900
Carsten Haitzler <raster@rasterman.com> wrote:

> On Fri, 15 Sep 2017 19:12:52 +0200 Davide Andreoli
> <dave@gurumeditation.it> said:
> 
> > 2017-09-15 14:46 GMT+02:00 Daniel Zaoui <daniel.zaoui@samsung.com>:
> > 
> > > jackdanielz pushed a commit to branch master.
> > > 
> > > http://git.enlightenment.org/core/efl.git/commit/?id=
> > > 1a9e739ebc03f42ea364b108c9cbaf8ed005d55c
> > > 
> > > commit 1a9e739ebc03f42ea364b108c9cbaf8ed005d55c
> > > Author: Daniel Zaoui <daniel.zaoui@yahoo.com>
> > > Date:   Tue Sep 5 22:41:30 2017 +0300
> > > 
> > > Tests: fix remote image
> > > 
> > > URL was wrong as the server seems down.
> > > Additionally, the two last lines have been swapped so the
> > > application seems normal and not stretched.
> > > ---
> > > src/bin/elementary/test_image.c | 5 +++--
> > > 1 file changed, 3 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/src/bin/elementary/test_image.c
> > > b/src/bin/elementary/test_ image.c
> > > index fd59a63c56..922a8a98fe 100644
> > > --- a/src/bin/elementary/test_image.c
> > > +++ b/src/bin/elementary/test_image.c
> > > @@ -304,7 +304,8 @@ test_remote_image(void *data EINA_UNUSED,
> > > Evas_Object *obj  EINA_UNUSED, void *e
> > > elm_entry_single_line_set(o, 1);
> > > evas_object_size_hint_weight_set(o, EVAS_HINT_EXPAND, 0);
> > > evas_object_size_hint_align_set(o, EVAS_HINT_FILL,
> > > EVAS_HINT_FILL);
> > > -   elm_object_text_set(o, "http://41.media.tumblr.com/
> > > 29f1ecd4f98aaff73fb21f479b450d4c/tumblr_mqsxdciQmB1rrju89o1_1280.jpg");
> > > +   //elm_object_text_set(o, "http://41.media.tumblr.com/
> > > 29f1ecd4f98aaff73fb21f479b450d4c/tumblr_mqsxdciQmB1rrju89o1_1280.jpg");
> > > +   elm_object_text_set(o, "http://68.media.tumblr.com/
> > > d14765b2cc4ec25d1e7d640f3ec77a40/tumblr_ohtpjtRNlm1rrju89o1_500.jpg");
> > > evas_object_smart_callback_add(o, "activated",
> > > _url_activate_cb, win); elm_box_pack_end(box2, o);
> > > evas_object_show(o);
> > > @@ -315,8 +316,8 @@ test_remote_image(void *data EINA_UNUSED,
> > > Evas_Object *obj  EINA_UNUSED, void *e
> > > // set file now
> > > _url_activate_cb(win, o, NULL);
> > > 
> > > -   evas_object_resize(win, 320, 480);
> > > evas_object_show(win);
> > > +   evas_object_resize(win, 320, 480);
> > > 
> > 
> > 
> > This last line swap is somehow wrong, you are hiding a bug, or a t
> > least a regression.  
> 
> agreed.

I am sure this is not the best way to solve the size problem. This kind of issue \
(window size) has always been there (as far as I remember). Even resize_object_add \
triggers this issue (see T5876). I didn't think this change was critical.

> 
> > @jpeg can you please check this one?
> > 
> > 
> > 
> > > }
> > > 
> > > static void
> > > 
> > > --
> > > 
> > > 
> > > 
> > ------------------------------------------------------------------------------
> > Check out the vibrant tech community on one of the world's most
> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> > _______________________________________________
> > enlightenment-devel mailing list
> > enlightenment-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
> > 
> 
> 


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[prev in list] [next in list] [prev in thread] [next in thread]