[prev in list] [next in list] [prev in thread] [next in thread] 

List:       enlightenment-devel
Subject:    Re: [E-devel] =?utf-8?q?=5BEGIT=5D_=5Bcore/elementary=5D_master_01/01?=
From:       ChunEon Park <hermet () naver ! com>
Date:       2015-09-08 2:30:38
Message-ID: 4f7dbb24de53999afa46fb680e6eeb0 () cweb28 ! nm ! nhnsystem ! com
[Download RAW message or body]

just hoping devs review  api additions more carefully.
thanks.

------------------------------------
-Regards, Hermet-

-----Original Message-----
From: "Amitesh Singh"<singh.amitesh@gmail.com> 
To: "Enlightenment developer list"<enlightenment-devel@lists.sourceforge.net>; 
Cc: 
Sent: 2015-09-08 (화) 02:01:16
Subject: Re: [E-devel] [EGIT] [core/elementary] master 01/01: hoversel: rename api \
scroll_enabled_set to scrollable_set  
Hello Hermet,

Thanks for fixing. Its good that you renamed this API before release.

Thanks
Amitesh


On Mon, Sep 7, 2015 at 5:13 PM, ChunEon Park <hermet@hermet.pe.kr> wrote:

> hermet pushed a commit to branch master.
> 
> 
> http://git.enlightenment.org/core/elementary.git/commit/?id=d73ff4601193218e92867052d533ee4b686ae8fb
>  
> commit d73ff4601193218e92867052d533ee4b686ae8fb
> Author: ChunEon Park <hermet@hermet.pe.kr>
> Date:   Mon Sep 7 20:41:34 2015 +0900
> 
> hoversel: rename api scroll_enabled_set to scrollable_set
> 
> modify api for consistency.
> scrollable_set is more closed to other similar apis.
> ---
> src/bin/test_hoversel.c  2 +-
> src/lib/elc_hoversel.c   6 +++---
> src/lib/elm_hoversel.eo  9 ++++++---
> 3 files changed, 10 insertions(+), 7 deletions(-)
> 
> diff --git a/src/bin/test_hoversel.c b/src/bin/test_hoversel.c
> index 26977dd..8fd2346 100644
> --- a/src/bin/test_hoversel.c
> +++ b/src/bin/test_hoversel.c
> @@ -181,7 +181,7 @@ test_hoversel(void *data EINA_UNUSED, Evas_Object *obj
> EINA_UNUSED, void *event_
> evas_object_show(hoversel);
> 
> hoversel = elm_hoversel_add(win);
> -   elm_hoversel_scroll_enabled_set(hoversel, EINA_TRUE);
> +   elm_hoversel_scrollable_set(hoversel, EINA_TRUE);
> elm_hoversel_hover_parent_set(hoversel, win);
> elm_object_text_set(hoversel, "Some Icons");
> elm_hoversel_item_add(hoversel, "Item 1", NULL, ELM_ICON_NONE, NULL,
> NULL);
> diff --git a/src/lib/elc_hoversel.c b/src/lib/elc_hoversel.c
> index a8bb528..c25fb6a 100644
> --- a/src/lib/elc_hoversel.c
> +++ b/src/lib/elc_hoversel.c
> @@ -777,13 +777,13 @@
> _elm_hoversel_elm_interface_atspi_widget_action_elm_actions_get(Eo *obj
> EINA_UNU
> }
> 
> EOLIAN void
> -_elm_hoversel_scroll_enabled_set(Eo *obj EINA_UNUSED, Elm_Hoversel_Data
> *sd, Eina_Bool scroll_enabled)
> +_elm_hoversel_scrollable_set(Eo *obj EINA_UNUSED, Elm_Hoversel_Data *sd,
> Eina_Bool scroll)
> {
> -   sd->scroll_enabled = !!scroll_enabled;
> +   sd->scroll_enabled = !!scroll;
> }
> 
> EOLIAN Eina_Bool
> -_elm_hoversel_scroll_enabled_get(Eo *obj EINA_UNUSED, Elm_Hoversel_Data
> *sd)
> +_elm_hoversel_scrollable_get(Eo *obj EINA_UNUSED, Elm_Hoversel_Data *sd)
> {
> return sd->scroll_enabled;
> }
> diff --git a/src/lib/elm_hoversel.eo b/src/lib/elm_hoversel.eo
> index 36f4e76..878b454 100644
> --- a/src/lib/elm_hoversel.eo
> +++ b/src/lib/elm_hoversel.eo
> @@ -42,16 +42,19 @@ class Elm.Hoversel (Elm.Button,
> Evas.Selectable_Interface,
> return: const(list<Elm.Widget_Item *>)*;
> }
> }
> -      @property scroll_enabled {
> +      @property scrollable {
> [[Control wether scrolling is enabled.
> 
> -           This Limit the size of contents and make them scrollable.]]
> +           This Limit the size of contents and make them scrollable.
> +
> +           @since 1.16
> +         ]]
> get {
> }
> set {
> }
> values {
> -            scroll_enabled: bool; [[$true if scrollable $false
> otherwise.]]
> +            scrollable: bool; [[$true if scrollable $false otherwise.]]
> }
> }
> hover_begin {
> 
> --
> 
> 
> 
------------------------------------------------------------------------------
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
------------------------------------------------------------------------------
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[prev in list] [next in list] [prev in thread] [next in thread]