[prev in list] [next in list] [prev in thread] [next in thread] 

List:       enlightenment-devel
Subject:    [E-devel] patch : fix e border reset to default
From:       Laurent Ghigonis <ooookiwi () gmail ! com>
Date:       2009-11-22 23:22:02
Message-ID: 20091122232202.0bbc5a04 () gmail ! com
[Download RAW message or body]

noticed that when you set default border to "borderless", it gets
reseted to "default" every time a border is displayed with a flag like
urgent ?

here is a fix, can someone review it ? i don't have an overview of
e_border.
when can't find the wanted border, it tries the user default
border before reseting it to theme default.

thanks,
laurent

[Attachment #3 (text/x-patch)]

Index: src/bin/e_border.c
===================================================================
--- src/bin/e_border.c	(revision 43803)
+++ src/bin/e_border.c	(working copy)
@@ -6166,16 +6166,22 @@
 	     ok = e_theme_edje_object_set(o, "base/theme/borders", buf);
 	     if ((!ok) && (strcmp(bd->client.border.name, "borderless")))
 	       {
-		  ok = e_theme_edje_object_set(o, "base/theme/borders",
-					       "e/widgets/border/default/border");
-		  if (ok) 
-		    {
-		       /* Reset default border style to default */
-		       if (e_config->theme_default_border_style)
-			 eina_stringshare_del(e_config->theme_default_border_style);
-		       e_config->theme_default_border_style = eina_stringshare_add("default");
-		       e_config_save_queue();
-		    }
+		   snprintf(buf, sizeof(buf), "e/widgets/border/%s/border",
+			   e_config->theme_default_border_style);
+		   ok = e_theme_edje_object_set(o, "base/theme/borders", buf);
+		   if (!ok && (strcmp(e_config->theme_default_border_style, "borderless")))
+		     {
+			ok = e_theme_edje_object_set(o, "base/theme/borders",
+						     "e/widgets/border/default/border");
+			if (!ok) 
+			  {
+			     /* Reset default border style to default */
+			     if (e_config->theme_default_border_style)
+			       eina_stringshare_del(e_config->theme_default_border_style);
+			     e_config->theme_default_border_style = eina_stringshare_add("default");
+			     e_config_save_queue();
+			  }
+		     }
 	       }
 
 	     bd->shaped = 0;


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel


[prev in list] [next in list] [prev in thread] [next in thread]