[prev in list] [next in list] [prev in thread] [next in thread] 

List:       enlightenment-devel
Subject:    Re: [E-devel] E SVN: morlenxus trunk/entrance/src/client
From:       Sebastian Dransfeld <sebastid () tango ! flipp ! net>
Date:       2008-08-31 13:58:42
Message-ID: 48BAA392.1060700 () tango ! flipp ! net
[Download RAW message or body]

no-reply@enlightenment.org wrote:
> Author:       morlenxus
> Date:         2008-08-30 15:38:34 -0700 (Sat, 30 Aug 2008)
> New Revision: 35754
> 
> Modified:
>   trunk/entrance/src/client/entrance_session.c 
> Log:
> 
> pam_ssh patch by Joerg
> 
> 
> Modified: trunk/entrance/src/client/entrance_session.c
> ===================================================================
> --- trunk/entrance/src/client/entrance_session.c	2008-08-30 22:34:26 UTC (rev 35753)
> +++ trunk/entrance/src/client/entrance_session.c	2008-08-30 22:38:34 UTC (rev 35754)
> @@ -450,6 +450,8 @@
>  #ifdef HAVE_PAM
>     if (e->config->auth == ENTRANCE_USE_PAM)
>     {
> +      char **pamenv, **envitem;
> +
>        /* Tell PAM that session has begun */
>        if (pam_open_session(e->auth->pam.handle, 0) != PAM_SUCCESS)
>        {
> @@ -461,6 +463,18 @@
>              return;
>           }
>        }
> +
> +      if ((pamenv = pam_getenvlist(e->auth->pam.handle)) != NULL)
> +      {
> +	for (envitem = pamenv; *envitem; envitem++)
> +	{
> +	  putenv(*envitem);
> +	  free(*envitem);

According to how putenv works, you can't free memory passed to it.

Sebastian

> +	}
> +
> +	free(pamenv);
> +     }
> +
>        syslog(LOG_INFO, "Opened PAM session. %s : %s.", e->auth->pw->pw_name,
>               e->display);
>     }
> 
> 
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> enlightenment-svn mailing list
> enlightenment-svn@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/enlightenment-svn


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[prev in list] [next in list] [prev in thread] [next in thread]