[prev in list] [next in list] [prev in thread] [next in thread] 

List:       elinks-dev
Subject:    [elinks-dev] Re: [ELinks] elinks - pasky: Enhance error reporting to
From:       Jonas Fonseca <fonseca () diku ! dk>
Date:       2004-10-23 14:06:17
Message-ID: 20041023140617.GE16295 () diku ! dk
[Download RAW message or body]

cvs@pasky.or.cz <cvs@pasky.or.cz> wrote Fri, Oct 22, 2004:
> This is an automated notification of a change to the ELinks CVS tree.
> 
> Author: pasky
> Module: elinks
> Tag: <TRUNK>
> Date: Fri Oct 22 07:36:46 2004 GMT
> 
> ---- Log message:
> 
> Enhance error reporting to report what kind of thing it actually is, and SetOptions \
> VAROBJFIX and COMPILE_N_GO, which should improve things and fix language-wise buggy \
> behaviour. Sorry for combining those two trivial patches, I'm in hurry. 
> 
> ---- Files affected:
> 
> elinks/src/ecmascript:
> spidermonkey.c (1.60 -> 1.61) 
> http://cvsweb.elinks.or.cz/cvsweb.cgi/elinks/src/ecmascript/spidermonkey.c.diff?r1=1.60&r2=1.61&f=u
>  
> 
> ---- Diffs:
> 
> elinks/src/ecmascript/spidermonkey.c |   10 +++++++++-
> 1 files changed, 9 insertions(+), 1 deletion(-)
> 
> 
> Index: elinks/src/ecmascript/spidermonkey.c
> diff -u elinks/src/ecmascript/spidermonkey.c:1.60 \
>                 elinks/src/ecmascript/spidermonkey.c:1.61
> --- elinks/src/ecmascript/spidermonkey.c:1.60	Fri Oct 22 01:11:55 2004
> +++ elinks/src/ecmascript/spidermonkey.c	Fri Oct 22 09:36:40 2004
> @@ -910,8 +910,12 @@
> 		report->linebuf && report->tokenptr
> 		?
> 		msg_text(term, N_("A script embedded in the current "
> -		         "document raised the following exception: "
> +		         "document raised the following%s%s%s%s: "
> 		         "\n\n%s\n\n%s\n.%*s^%*s."),
> +		         JSREPORT_IS_STRICT(report->flags) ? " strict" : "",
> +		         JSREPORT_IS_EXCEPTION(report->flags) ? " exception" : "",
> +		         JSREPORT_IS_WARNING(report->flags) ? " warning" : "",
> +		         !report->flags ? " error" : "",
> 		         message,
> 			 report->linebuf,
> 			 report->tokenptr - report->linebuf - 2, " ",

Eeek! This thing is multiplying, so there is even more reason for making
refactoring it.

[removed last patch chunk]

-- 
Jonas Fonseca
_______________________________________________
ELinks-dev mailing list
ELinks-dev@linuxfromscratch.org
http://linuxfromscratch.org/mailman/listinfo/elinks-dev


[prev in list] [next in list] [prev in thread] [next in thread]