[prev in list] [next in list] [prev in thread] [next in thread] 

List:       elinks-dev
Subject:    [elinks-dev] Re: elinks - jonas: Do all the submit handling in
From:       Jonas Fonseca <fonseca () diku ! dk>
Date:       2004-07-25 6:49:25
Message-ID: 20040725064925.GA27789 () diku ! dk
[Download RAW message or body]

Petr Baudis <pasky@ucw.cz> wrote Sat, Jul 24, 2004:
> Dear diary, on Sun, Jun 20, 2004 at 03:11:39PM CEST, I got a letter,
> where cvs@pasky.or.cz told me, that...
> > This is an automated notification of a change to the ELinks CVS tree.
> > 
> > Author: jonas
> > Module: elinks
> > Tag: <TRUNK>
> > Date: Sun Jun 20 13:11:39 2004 GMT
> > 
> > ---- Log message:
> > 
> > Do all the submit handling in field_op() and don't fall back to enter(). \
> > ACT_EDIT_ENTER and ACT_MAIN_ENTER might not be bound to the same thing, so this \
> > is more correct. However we should probably add ACT_EDIT_ENTER_RELOAD to keep the \
> > feature set complete. 
> > 
> > ---- Files affected:
> > 
> > elinks/src/viewer/text:
> > form.c (1.209 -> 1.210) 
> > http://cvsweb.elinks.or.cz/cvsweb.cgi/elinks/src/viewer/text/form.c.diff?r1=1.209&r2=1.210&f=u
> >  link.c (1.235 -> 1.236) 
> > http://cvsweb.elinks.or.cz/cvsweb.cgi/elinks/src/viewer/text/link.c.diff?r1=1.235&r2=1.236&f=u
> >  
> > 
> > ---- Diffs:
> > 
> > elinks/src/viewer/text/form.c |   14 +++++++++++---
> > elinks/src/viewer/text/link.c |   10 +---------
> > 2 files changed, 12 insertions(+), 12 deletions(-)
> > 
> > 
> > Index: elinks/src/viewer/text/link.c
> > diff -u elinks/src/viewer/text/link.c:1.235 elinks/src/viewer/text/link.c:1.236
> > --- elinks/src/viewer/text/link.c:1.235	Sat Jun 19 20:16:28 2004
> > +++ elinks/src/viewer/text/link.c	Sun Jun 20 15:11:34 2004
> > @@ -624,19 +624,11 @@
> > 	if (!link) return FRAME_EVENT_REFRESH;
> > 
> > 	if (!link_is_form(link)
> > -	    || link->type == LINK_BUTTON
> > -	    || ((has_form_submit(doc_view->document, link->form_control)
> > -		 || get_opt_int("document.browse.forms.auto_submit"))
> > -		&& link_is_textinput(link))) {
> > +	    || link->type == LINK_BUTTON) {
> > 
> > 		if (goto_current_link(ses, doc_view, do_reload))
> > 			return FRAME_EVENT_OK;
> > 
> > -	} else if (link_is_textinput(link)) {
> > -		/* We won't get here if (has_form_submit() ||
> > -		 * 			 get_opt_int("..")) */
> > -		down(ses, doc_view);
> > -
> > 	} else if (link->type == LINK_CHECKBOX) {
> > 		struct form_state *fs = find_form_state(doc_view, link->form_control);
> > 
> 
> Ad the second chunk, you removed it but did not readd the code anywhere
> else, therefore now when document.browse.forms.auto_submit is off, you
> do not move to the next link.

I want to revert that patch since it causes assertion failures when
pressing <Left> in text-input form-fields with insert mode being off.

Sorry I broke auto_submit. I hadn't figured out what the feature was
about.

-- 
Jonas Fonseca
_______________________________________________
ELinks-dev mailing list
ELinks-dev@linuxfromscratch.org
http://linuxfromscratch.org/mailman/listinfo/elinks-dev


[prev in list] [next in list] [prev in thread] [next in thread]