[prev in list] [next in list] [prev in thread] [next in thread] 

List:       e1000-devel
Subject:    Re: [E1000-devel] CONFIG_IGB_DISABLE_PACKET_SPLIT in igb nic driver
From:       zhuyj <zyjzyj2000 () gmail ! com>
Date:       2015-07-06 6:48:02
Message-ID: CAD=hENch1iifLchnqXkMWVn9Ap4gdizfgZSpzr=JeMS668SR=A () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi,

This patch can help the igb nic work well even with AH packets. Or else
this igb driver can not handle AH packets well.
You can make tests. You will find AH packets be discarded in receiver host.
And ICV error will be printed.

So this patch is very necessary to avoid the above problem.

Zhu Yanjun

On Mon, Jun 29, 2015 at 11:50 PM, Fujinaka, Todd <todd.fujinaka@intel.com>
wrote:

> I don't understand this comment. CONFIG_IGB_DISABLE_PACKET_SPLIT was
> introduced around the start of 2013 and igb started in 2007 sometime.
>
> Can't you just define CONFIG_IGB_PACKET_SPLIT?
>
> I don't think this patch is necessary.
>
> Also, this is the wrong mailing list - you should be posting kernel
> patches to intel-wired-lan@lists.osuosl.org.
>
> Todd Fujinaka
> Software Application Engineer
> Networking Division (ND)
> Intel Corporation
> todd.fujinaka@intel.com
> (503) 712-4565
>
> -----Original Message-----
> From: zhuyj [mailto:zyjzyj2000@gmail.com]
> Sent: Thursday, June 25, 2015 11:30 PM
> To: e1000-devel@lists.sourceforge.net
> Subject: [E1000-devel] CONFIG_IGB_DISABLE_PACKET_SPLIT in igb nic driver
>
> >From the beginning, CONFIG_IGB_DISABLE_PACKET_SPLIT is introduced in
> >igb
> nic driver.
> But this CONFIG_IGB_DISABLE_PACKET_SPLIT is not defined in linux kernel
> options.
> As such, igb nic driver will split packets.
>
> So if the patckets are protected by some hash algorithm, such as md5,
> sha1, after igb nic dirver splits long patckets(>178bytes), these protected
> packets will be discarded in the receiver.
>
> An example is AH packets. If the AH packets are long enough(>178), these
> AH packets will be splited in igb nic driver. In the end, the receiver will
> not get correct ICV result. So these long(>178 bytes) will be dicarded.
>
> So it is necessary to define CONFIG_IGB_DISABLE_PACKET_SPLIT in some igb
> driver header files to avoid splitting long packets in igb driver.
>
> At least, some explanations should be put in the README file. But there is
> nothing about CONFIG_IGB_DISABLE_PACKET_SPLIT in the README file.
>
> So we should apply this patch (based on igb 5.0.5) in our igb nic driver
> when it is built for linux kernel.
>
> Or some explanations should be put into the README file.
>
> Best Regards!
> Zhu Yanjun
>


------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/

_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired


[prev in list] [next in list] [prev in thread] [next in thread]