[prev in list] [next in list] [prev in thread] [next in thread] 

List:       e1000-devel
Subject:    [E1000-devel] ixgbe: BUG changing MTU or LRO setting disables VF multicast reception
From:       "Haller, John H (John)" <john.haller () alcatel-lucent ! com>
Date:       2013-06-29 15:12:44
Message-ID: 7C1824C61EE769448FCE74CD83F0CB4F57CCDB3B () US70TWXCHMBA11 ! zam ! alcatel-lucent ! com
[Download RAW message or body]

Any change to the device which causes ixgbe_do_reset to be called,
including things like changing LRO setting or changing the MTU, cause
the multicast table to be disabled. This prevents multicast packets
to be sent to VFs, which also disables IPv6 to the VFs.

As a quick hack, I added the following call to the end of ixgbe_set_vf_multicast:
       IXGBE_WRITE_REG(hw, IXGBE_MCSTCTRL,IXGBE_MCSTCTRL_MFE |
               hw->mac.mc_filter_type);

This fixed the immediate problem, but I don't think it's the right solution.
Part of the problem is that both the main part of the driver and the sriov
part of the driver are both writing to the chip's multicast table using different
data. The other part of the problem is that ixgbe_do_reset is not
restoring everything it disabled during the reset. Both ixgbe_set_vf_multicast
and ixgbe_update_mc_addr_list modify the same chip table (IXGBE_MTA), but only
one sets the IXGBE_MCSTCTRL_MFE bit which turns the table on. Normally,
this would leave the IXGBE_MCSTCTRL_MFE bit on, unless one does something
which resets the driver/chip.

Regards,
John Haller



------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired
[prev in list] [next in list] [prev in thread] [next in thread]