[prev in list] [next in list] [prev in thread] [next in thread] 

List:       e1000-devel
Subject:    Re: [E1000-devel] BUG: using smp_processor_id() in
From:       Stephen Hemminger <shemminger () vyatta ! com>
Date:       2010-04-22 21:54:35
Message-ID: 20100422145435.2416e313 () nehalam
[Download RAW message or body]

On Tue, 20 Apr 2010 12:19:43 +0800
<Ocean.Ma@Emerson.com> wrote:

> Checking https://bugzilla.kernel.org/show_bug.cgi?id=12518  This problem
> seems have been submitted as a bug of preempt kernel debugging function
> of debug_smp_processor_id() in kernel 2.6.28/29. A patch will fix the
> issue
> 

That is the wrong way to fix the issue.

The proper way is to use raw_smp_processor_id() instead.

In the IXGBE driver, it is mapping the current processor id to the transmit
queue if flow director is in use. Well the code there might get preempted
and run on another CPU, and the cpu id might change. But this is should
be okay in this case because it will only cause the packet to go out a different
queue.

Messing around with the  core smp_processor_id code is not the right answer.
-- 

------------------------------------------------------------------------------
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired
[prev in list] [next in list] [prev in thread] [next in thread]