[prev in list] [next in list] [prev in thread] [next in thread] 

List:       e1000-devel
Subject:    Re: [E1000-devel] [PATCH net-next] Return PCI_ERS_RESULT_DISCONNECT
From:       Jeff Kirsher <jeffrey.t.kirsher () intel ! com>
Date:       2009-04-24 0:39:42
Message-ID: 9929d2390904231739r5991c1cbwe8da7df578a232fd () mail ! gmail ! com
[Download RAW message or body]

On Thu, Apr 23, 2009 at 10:57 AM, Breno Leitao
<leitao@linux.vnet.ibm.com> wrote:
> According to the "PCI Error Recovery" document, if after a recovery, the
> bus is disabled, the error_detected function should return
> PCI_ERS_RESULT_DISCONNECT. Actually ixgbe error_detected function is
> always returning PCI_ERS_RESULT_NEED_RESET, even if the bus is in
> failure.
> This patch just check if the bus is disabled and then returns
> PCI_ERS_RESULT_DISCONNET.
>
> Signed-off-by: Breno Leitão <leitao@linux.vnet.ibm.com>
> ---
> diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
> index c45e4e7..2bccbcc 100644
> --- a/drivers/net/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ixgbe/ixgbe_main.c
> @@ -4939,6 +4939,9 @@ static pci_ers_result_t ixgbe_io_error_detected(struct pci_dev *pdev,
>
>        netif_device_detach(netdev);
>
> +       if (state == pci_channel_io_perm_failure)
> +               return PCI_ERS_RESULT_DISCONNECT;
> +
>        if (netif_running(netdev))
>                ixgbe_down(adapter);
>        pci_disable_device(pdev);
>

Thanks Breno, I have added your patch to my ixgbe patch queue.  We
will do some testing on the patch and then will push with the other
ixgbe patches I have for net-next.

-- 
Cheers,
Jeff

------------------------------------------------------------------------------
Crystal Reports &#45; New Free Runtime and 30 Day Trial
Check out the new simplified licensign option that enables unlimited
royalty&#45;free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel

[prev in list] [next in list] [prev in thread] [next in thread]