[prev in list] [next in list] [prev in thread] [next in thread] 

List:       e-lang
Subject:    Re: [e-lang] Bug: NetConfig() incompatible with VatTPMgr
From:       Mark Miller <erights () gmail ! com>
Date:       2010-01-13 4:59:52
Message-ID: fee0a56d1001122059g76bd2134i43264b3e073cd38e () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Fri, Jan 8, 2010 at 1:56 PM, Kevin Reid <kpreid@mac.com> wrote:

> I tried this and was surprised to find it fail:
>
>   ? introducer.setNetConfig(<import:net.vattp.data.makeNetConfig>())
>   ? introducer.onTheAir()
>   # problem: <NullPointerException>
>
> NetConfig.java:
>     public NetConfig() {
>         this(ConstList.EmptyList, ConstList.EmptyList, null);
>     }
>
>
> VatTPMgr.java:
>         ConstList listenPath = netConfig.getListenAddrPath();
>         if (0 == listenPath.size()) {
>             listenPath = listenPath.with(null);
>         }
>
> The ordinary NetConfig construction (NetConfig.make) always puts a
> (possibly empty) ConstList in listenAddrPath. Should the no-args
> constructor do the same thing, or is there an intended semantic
> distinction from having an empty list vs. no list?
>
> Just looked to remind myself. No intended semantics. Looks like a just made
a simple mistake. (When I do intend a variable to possibly hold null, I'm
rather consistent about including an "opt" in the name.) Thanks for figuring
this out.

Big fixed and change committed.



> --
> Kevin Reid                                  <http://switchb.org/kpreid/>
>
>
>
>
> _______________________________________________
> e-lang mailing list
> e-lang@mail.eros-os.org
> http://www.eros-os.org/mailman/listinfo/e-lang
>



-- 
Text by me above is hereby placed in the public domain

   Cheers,
   --MarkM

[Attachment #5 (text/html)]

On Fri, Jan 8, 2010 at 1:56 PM, Kevin Reid <span dir="ltr">&lt;<a \
href="mailto:kpreid@mac.com">kpreid@mac.com</a>&gt;</span> wrote:<br><div \
class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid \
rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> I tried this and \
was surprised to find it fail:<br> <br>
   ? introducer.setNetConfig(&lt;import:net.vattp.data.makeNetConfig&gt;())<br>
   ? introducer.onTheAir()<br>
   # problem: &lt;NullPointerException&gt;<br>
<br>
NetConfig.java:<br>
     public NetConfig() {<br>
         this(ConstList.EmptyList, ConstList.EmptyList, null);<br>
     }<br>
<br>
<br>
VatTPMgr.java:<br>
         ConstList listenPath = netConfig.getListenAddrPath();<br>
         if (0 == listenPath.size()) {<br>
             listenPath = listenPath.with(null);<br>
         }<br>
<br>
The ordinary NetConfig construction (NetConfig.make) always puts a<br>
(possibly empty) ConstList in listenAddrPath. Should the no-args<br>
constructor do the same thing, or is there an intended semantic<br>
distinction from having an empty list vs. no list?<br>
<br></blockquote><div>Just looked to remind myself. No intended semantics. Looks like \
a just made a simple mistake. (When I do intend a variable to possibly hold null, \
I&#39;m rather consistent about including an &quot;opt&quot; in the name.) Thanks for \
figuring this out.<br> <br>Big fixed and change committed.<br><br> </div><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
                0pt 0.8ex; padding-left: 1ex;">
--<br>
Kevin Reid                                  &lt;<a href="http://switchb.org/kpreid/" \
target="_blank">http://switchb.org/kpreid/</a>&gt;<br> <br>
<br>
<br>
<br>
_______________________________________________<br>
e-lang mailing list<br>
<a href="mailto:e-lang@mail.eros-os.org">e-lang@mail.eros-os.org</a><br>
<a href="http://www.eros-os.org/mailman/listinfo/e-lang" \
target="_blank">http://www.eros-os.org/mailman/listinfo/e-lang</a><br> \
</blockquote></div><br><br clear="all"><br>-- <br>Text by me above is hereby placed \
in the public domain<br><br>    Cheers,<br>    --MarkM<br><br>



_______________________________________________
e-lang mailing list
e-lang@mail.eros-os.org
http://www.eros-os.org/mailman/listinfo/e-lang


[prev in list] [next in list] [prev in thread] [next in thread]