[prev in list] [next in list] [prev in thread] [next in thread] 

List:       drill-dev
Subject:    Review Request 29519: DRILL-1885: fix a problem regarding ordinal to vector mapping that report inco
From:       "Hanifi Gunes" <hgunes () maprtech ! com>
Date:       2014-12-31 23:12:21
Message-ID: 20141231231221.31225.15243 () reviews ! apache ! org
[Download RAW message or body]

--===============2561304534343053528==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29519/
-----------------------------------------------------------

Review request for drill, Jacques Nadeau, Parth Chandra, and Steven Phillips.


Bugs: DRILL-1885
    https://issues.apache.org/jira/browse/DRILL-1885


Repository: drill-git


Description
-------

fix a problem regarding ordinal to vector mapping that report incorrect result or \
fails a query. fix failing unittest
refactor code, eliminate redundancy


Diffs
-----

  common/src/main/java/org/apache/drill/common/collections/MapWithOrdinal.java \
PRE-CREATION   exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScanBatch.java \
23833b6   exec/java-exec/src/main/java/org/apache/drill/exec/record/VectorContainer.java \
d50760a   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/AbstractContainerVector.java \
1210d90   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/MapVector.java \
cc3d24c   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedListVector.java \
362d806   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java \
e140c8b   exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/VectorWithOrdinal.java \
PRE-CREATION   exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetComplex.java \
8405d0e   exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/fn/TestJsonReaderWithSparseFiles.java \
7e4cf4b 

Diff: https://reviews.apache.org/r/29519/diff/


Testing
-------

unit tests + all test suites pass.


Thanks,

Hanifi Gunes


--===============2561304534343053528==--


[prev in list] [next in list] [prev in thread] [next in thread]