[prev in list] [next in list] [prev in thread] [next in thread] 

List:       drill-dev
Subject:    Re: Review Request 29381: DRILL-1468 : CPP Client doesn't handle cancels correctly
From:       "Parth Chandra" <pchandra () maprtech ! com>
Date:       2014-12-24 0:15:43
Message-ID: 20141224001543.10624.84989 () reviews ! apache ! org
[Download RAW message or body]

--===============8867531293811738910==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29381/
-----------------------------------------------------------

(Updated Dec. 24, 2014, 12:15 a.m.)


Review request for drill, Hanifi Gunes, Norris Lee, and Xiao Meng.


Summary (updated)
-----------------

DRILL-1468 : CPP Client doesn't handle cancels correctly


Repository: drill-git


Description
-------

The handling of the termination states of a query were not handled correctly in the \
C++client especially when a query was cancelled. Queries that have been canceled or \
for which the client app has free'd the resources, are tracked in a pendingQueries \
list. The entry is cleared when the last batch with a terminal state is received. \
Record batches that arrive for any query that is in 'pending' are silently consumed \
and never passed on to the app.


Diffs
-----

  contrib/native/client/example/querySubmitter.cpp 7b98bc9 
  contrib/native/client/src/clientlib/drillClientImpl.hpp 8e2f437 
  contrib/native/client/src/clientlib/drillClientImpl.cpp cc70020 
  contrib/native/client/src/clientlib/errmsgs.cpp 7a7fa6a 
  contrib/native/client/src/include/drill/common.hpp 59537f1 

Diff: https://reviews.apache.org/r/29381/diff/


Testing
-------

Ran test queries using the query submitter example program in both sync and async \
APIs with and without cancellation of queries. Tested on Windows, Mac and Linux.


Thanks,

Parth Chandra


--===============8867531293811738910==--


[prev in list] [next in list] [prev in thread] [next in thread]