From dri-devel Wed Jun 28 05:21:25 2023 From: Zack Rusin Date: Wed, 28 Jun 2023 05:21:25 +0000 To: dri-devel Subject: [PATCH v4 0/8] Fix cursor planes with virtualized drivers Message-Id: <20230628052133.553154-1-zack () kde ! org> X-MARC-Message: https://marc.info/?l=dri-devel&m=168792967809277 From: Zack Rusin v4: Make drm_plane_create_hotspot_properties static, rename DRM_CLIENT_CAP_VIRTUALIZED_CURSOR_PLANE to DRM_CLIENT_CAP_CURSOR_PLANE_HOTSPOT and some minor stylistic fixes for things found by Javier and Pekka in v3. v3: Renames, fixes and cleanups suggested by Daniel, Simon and Pekka after v2. There's no major changes in functionality. Please let me know if I missed anything, it's been a while since v2. Virtualized drivers have had a lot of issues with cursor support on top of atomic modesetting. This set both fixes the long standing problems with atomic kms and virtualized drivers and adds code to let userspace use atomic kms on virtualized drivers while preserving functioning seamless cursors between the host and guest. The first change in the set is one that should be backported as far as possible, likely 5.4 stable, because earlier stable kernels do not have virtualbox driver. The change makes virtualized drivers stop exposing a cursor plane for atomic clients, this fixes mouse cursor on all well formed compositors which will automatically fallback to software cursor. The rest of the changes until the last one ports the legacy hotspot code to atomic plane properties. Finally the last change introduces userspace API to let userspace clients advertise the fact that they are aware of additional restrictions placed upon the cursor plane by virtualized drivers and lets them use atomic kms with virtualized drivers (the clients are expected to set hotspots correctly when advertising support for virtual cursor plane). Zack Rusin (8): drm: Disable the cursor plane on atomic contexts with virtualized drivers drm/atomic: Add support for mouse hotspots drm/vmwgfx: Use the hotspot properties from cursor planes drm/qxl: Use the hotspot properties from cursor planes drm/vboxvideo: Use the hotspot properties from cursor planes drm/virtio: Use the hotspot properties from cursor planes drm: Remove legacy cursor hotspot code drm: Introduce DRM_CLIENT_CAP_CURSOR_PLANE_HOTSPOT drivers/gpu/drm/drm_atomic_state_helper.c | 14 +++++ drivers/gpu/drm/drm_atomic_uapi.c | 20 +++++++ drivers/gpu/drm/drm_ioctl.c | 9 ++++ drivers/gpu/drm/drm_plane.c | 64 ++++++++++++++++++++++- drivers/gpu/drm/qxl/qxl_display.c | 14 +++-- drivers/gpu/drm/qxl/qxl_drv.c | 2 +- drivers/gpu/drm/vboxvideo/vbox_drv.c | 2 +- drivers/gpu/drm/vboxvideo/vbox_mode.c | 4 +- drivers/gpu/drm/virtio/virtgpu_drv.c | 3 +- drivers/gpu/drm/virtio/virtgpu_plane.c | 8 +-- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 9 +--- include/drm/drm_drv.h | 9 ++++ include/drm/drm_file.h | 12 +++++ include/drm/drm_framebuffer.h | 12 ----- include/drm/drm_plane.h | 14 +++++ include/uapi/drm/drm.h | 25 +++++++++ 17 files changed, 184 insertions(+), 39 deletions(-) -- 2.39.2