[prev in list] [next in list] [prev in thread] [next in thread] 

List:       dri-devel
Subject:    Re: [Intel-gfx] [PATCH] drm/i915/guc: Dump perf_limit_reasons for debug
From:       "Belgaumkar, Vinay" <vinay.belgaumkar () intel ! com>
Date:       2023-06-27 4:02:14
Message-ID: 8c1b95aa-29c3-35dd-d0cc-609449a6730c () intel ! com
[Download RAW message or body]


On 6/26/2023 8:17 PM, Dixit, Ashutosh wrote:
> On Mon, 26 Jun 2023 19:12:18 -0700, Vinay Belgaumkar wrote:
> > GuC load takes longer sometimes due to GT frequency not ramping up.
> > Add perf_limit_reasons to the existing warn print to see if frequency
> > is being throttled.
> > 
> > Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> > ---
> > drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c | 2 ++
> > 1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c \
> > b/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c index 364d0d546ec8..73911536a8e7 \
> >                 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_fw.c
> > @@ -254,6 +254,8 @@ static int guc_wait_ucode(struct intel_guc *guc)
> > 		guc_warn(guc, "excessive init time: %lldms! [freq = %dMHz, before = %dMHz, \
> > status = 0x%08X, count = %d, ret = %d]\n",  delta_ms, \
> > intel_rps_read_actual_frequency(&uncore->gt->rps),  before_freq, status, count, \
> > ret); +		guc_warn(guc, "perf limit reasons = 0x%08X\n",
> > +			 intel_uncore_read(uncore, intel_gt_perf_limit_reasons_reg(gt)));
> Maybe just add at the end of the previous guc_warn?

Its already too long a line. If I try adding on the next line checkpatch 
complains about splitting double quotes.

Thanks,

Vinay.

> 
> > 	} else {
> > 		guc_dbg(guc, "init took %lldms, freq = %dMHz, before = %dMHz, status = 0x%08X, \
> > count = %d, ret = %d\n",  delta_ms, \
> >                 intel_rps_read_actual_frequency(&uncore->gt->rps),
> > -- 
> > 2.38.1
> > 


[prev in list] [next in list] [prev in thread] [next in thread]