[prev in list] [next in list] [prev in thread] [next in thread]
List: dri-devel
Subject: Re: [PATCH] i915: Drop legacy execbuffer support
From: Jason Ekstrand <jason () jlekstrand ! net>
Date: 2021-03-12 4:31:33
Message-ID: 17824b43488.2817.c6988b7ea6112e3e892765a0d4287e0c () jlekstrand ! net
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
On March 11, 2021 20:26:06 "Dixit, Ashutosh" <ashutosh.dixit@intel.com> wrote:
> On Wed, 10 Mar 2021 13:00:49 -0800, Jason Ekstrand wrote:
>>
>> libdrm has supported the newer execbuffer2 ioctl and using it by default
>> when it exists since libdrm commit b50964027bef249a0cc3d511de05c2464e0a1e22
>> which landed Mar 2, 2010. The i915 and i965 drivers in Mesa at the time
>> both used libdrm and so did the Intel X11 back-end. The SNA back-end
>> for X11 has always used execbuffer2.
>>
>> Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>
>> ---
>> .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 100 ------------------
>> drivers/gpu/drm/i915/gem/i915_gem_ioctls.h | 2 -
>> drivers/gpu/drm/i915/i915_drv.c | 2 +-
>> 3 files changed, 1 insertion(+), 103 deletions(-)
>
> Don't we want to clean up references to legacy execbuffer in
> include/uapi/drm/i915_drm.h too?
I thought about that but Daniel said we should leave them. Maybe a comment
is in order?
--Jason
[Attachment #5 (text/html)]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" \
"http://www.w3.org/TR/html4/loose.dtd"> <html>
<body>
<div dir="auto">
<div dir="auto"><br></div><div dir="auto"><span style="font-size: 12pt;">On March 11, \
2021 20:26:06 "Dixit, Ashutosh" <ashutosh.dixit@intel.com> \
wrote:</span></div><div id="aqm-original" style="color: black;"> <div><br></div>
<blockquote type="cite" class="gmail_quote" style="margin: 0 0 0 0.75ex; border-left: \
1px solid #808080; padding-left: 0.75ex;"> <div dir="auto">On Wed, 10 Mar 2021 \
13:00:49 -0800, Jason Ekstrand wrote:</div> <blockquote type="cite" \
class="gmail_quote" style="margin: 0 0 0 0.75ex; border-left: 1px solid #0099CC; \
padding-left: 0.75ex;"> <div dir="auto"><br></div>
<div dir="auto">libdrm has supported the newer execbuffer2 ioctl and using it by \
default</div> <div dir="auto">when it exists since libdrm commit \
b50964027bef249a0cc3d511de05c2464e0a1e22</div> <div dir="auto">which landed Mar 2, \
2010. The i915 and i965 drivers in Mesa at the time</div> <div dir="auto">both \
used libdrm and so did the Intel X11 back-end. The SNA back-end</div> <div \
dir="auto">for X11 has always used execbuffer2.</div> <div dir="auto"><br></div>
<div dir="auto">Signed-off-by: Jason Ekstrand <jason@jlekstrand.net></div>
<div dir="auto">---</div>
<div dir="auto">.../gpu/drm/i915/gem/i915_gem_execbuffer.c | 100 \
------------------</div> <div dir="auto">drivers/gpu/drm/i915/gem/i915_gem_ioctls.h \
| 2 -</div> <div dir="auto">drivers/gpu/drm/i915/i915_drv.c \
| 2 +-</div> <div \
dir="auto">3 files changed, 1 insertion(+), 103 deletions(-)</div> </blockquote>
<div dir="auto"><br></div>
<div dir="auto">Don't we want to clean up references to legacy execbuffer in</div>
<div dir="auto">include/uapi/drm/i915_drm.h too?</div>
</blockquote>
</div><div dir="auto"><br></div><div dir="auto">I thought about that but Daniel said \
we should leave them. Maybe a comment is in order?</div><div \
dir="auto"><br></div><div dir="auto">--Jason</div><div dir="auto"><br></div> \
</div></body> </html>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic