[prev in list] [next in list] [prev in thread] [next in thread] 

List:       dri-devel
Subject:    Re: [Dri-devel] radeon: pageflipping & CRTC{,2}_OFFSET_{,CNTL}
From:       Michel =?ISO-8859-1?Q?D=E4nzer?= <michel () daenzer ! net>
Date:       2002-10-29 13:55:23
[Download RAW message or body]

On Die, 2002-10-29 at 12:43, Jacek Rosik wrote:
> 
> ----- Original Message -----
> From: "Michel Dänzer" <michel@daenzer.net>
> To: <dri-devel@lists.sourceforge.net>
> Sent: Monday, October 28, 2002 2:38 AM
> Subject: [Dri-devel] radeon: pageflipping & CRTC{,2}_OFFSET_{,CNTL}
> 
> 
> >
> > http://penguinppc.org/~daenzer/DRI/radeon-pageflip.diff
> >
> > is an attempt to fix the following pageflipping issues:
> >
> >     * the 2D driver clobbers the CRTC{,2}_OFFSET_CNTL registers when
> >       switching modes; as a consequence, flips only take place on the
> >       next vertical blank, so you can see the back buffer being drawn to
> >     * the 2D driver AdjustFrame() function doesn't take the current page
> >       into account
> >     * the DRM doesn't take the viewport position into account, so the
> >       viewport is always reset to the upper left on a flip
> >     * the DRM doesn't handle CRTC2 (for CloneMode)
> >
> >  I can't fully test it, people who have reported any of these items (in
> > particular Jacek Rosik IIRC :) please give it a spin and let me know if
> > it helps.
> 
> Unfortunately there is a bug. In radeon_state.c (radeon_cp_dispatch_flip)
> dev_priv->front_pitch is not in pixels but in bytes. So it must not be
> multipied by bpp. With following change everything seems to be ok.
> http://stud.ics.p.lodz.pl/~paproch/dri/radeon_state.c.diff

Thanks, I've fixed that and a couple other things, cleaned it up a bit
and committed
http://penguinppc.org/~daenzer/DRI/applied/radeon-pageflip.diff .


> BTW:  Pitch is more than (max screen width)*4 in my case pitch~7680 with max
> width 1280.

Yes, this is a buglet related to RandR.

> I think this is what caused problems with xawtv.

That's what I thought, something is probably using the virtual width
instead of the pitch. The X server code looks correct though.


-- 
Earthling Michel Dänzer (MrCooper)/ Debian GNU/Linux (powerpc) developer
XFree86 and DRI project member   /  CS student, Free Software enthusiast



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
[prev in list] [next in list] [prev in thread] [next in thread]