[prev in list] [next in list] [prev in thread] [next in thread] 

List:       drbd-user
Subject:    Re: [DRBD-user] [PATCH] drivers: block: drbd: remove unused macros
From:       Roland Kammerer <roland.kammerer () linbit ! com>
Date:       2015-12-27 18:03:43
Message-ID: 20151227180343.GA63186 () rck ! sh
[Download RAW message or body]

On Sun, Dec 27, 2015 at 09:18:09PM +0700, Ivan Safonov wrote:
> div_ceil and div_floor macros duplicates round_up and round_down from kernel.h
> 
> Signed-off-by: Ivan Safonov <insafonov@gmail.com>
> ---
>  drivers/block/drbd/drbd_int.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/block/drbd/drbd_int.h b/drivers/block/drbd/drbd_int.h
> index e66d453..08256ad 100644
> --- a/drivers/block/drbd/drbd_int.h
> +++ b/drivers/block/drbd/drbd_int.h
> @@ -195,11 +195,6 @@ drbd_insert_fault(struct drbd_device *device, unsigned int type) {
>  #endif
>  }
>  
> -/* integer division, round _UP_ to the next integer */
> -#define div_ceil(A, B) ((A)/(B) + ((A)%(B) ? 1 : 0))
> -/* usual integer division */
> -#define div_floor(A, B) ((A)/(B))
> -
>  extern struct ratelimit_state drbd_ratelimit_state;
>  extern struct idr drbd_devices; /* RCU, updates: genl_lock() */
>  extern struct list_head drbd_resources; /* RCU, updates: genl_lock() */

Hi Ivan,

this is already gone from our internal repo, so it should land in
mainline anytime soon.

Thanks anyways, rck
_______________________________________________
drbd-user mailing list
drbd-user@lists.linbit.com
http://lists.linbit.com/mailman/listinfo/drbd-user
[prev in list] [next in list] [prev in thread] [next in thread]