'Re: [Drbd-dev] [RFC PATCH 02/34] block: introduce and use bio_new'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       drbd-dev
Subject:    Re: [Drbd-dev] [RFC PATCH 02/34] block: introduce and use bio_new
From:       Chaitanya Kulkarni <Chaitanya.Kulkarni () wdc ! com>
Date:       2021-01-28 8:34:28
Message-ID: DM6PR04MB497297B2D0CB8DF8894EB65386BA9 () DM6PR04MB4972 ! namprd04 ! prod ! outlook ! com
[Download RAW message or body]

On 1/27/21 11:27 PM, Damien Le Moal wrote:

+
+       bio_set_dev(bio, bdev);
+       bio->bi_iter.bi_sector = sector;
+       bio_set_op_attrs(bio, op, op_flags);

This function is obsolete. Open code this.

And that also mean that you could remove one argument to bio_new(): combine op
and op_flags into "unsigned int opf"

I did that initially but kept it separate for RFC, that is much easier than having

an extra arg, will change it in V1.

[Attachment #3 (text/html)]

<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body>
<div class="moz-cite-prefix">On 1/27/21 11:27 PM, Damien Le Moal wrote:<br>
</div>
<blockquote type="cite" \
cite="mid:BL0PR04MB6514DBA7EDB8EC87A1C20871E7BA9@BL0PR04MB6514.namprd04.prod.outlook.com">
 <blockquote type="cite" style="color: #007cff;">
<blockquote type="cite" style="color: #007cff;">
<pre class="moz-quote-pre" wrap="">+
+	bio_set_dev(bio, bdev);
+	bio-&gt;bi_iter.bi_sector = sector;
+	bio_set_op_attrs(bio, op, op_flags);
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">This function is obsolete. Open code this.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">And that also mean that you could remove one \
argument to bio_new(): combine op and op_flags into &quot;unsigned int opf&quot;

</pre>
</blockquote>
<p><font face="monospace">I did that initially but kept it separate for RFC, that is \
much easier than having</font></p> <p><font face="monospace">an extra arg, will \
change it in V1.</font><br> </p>
</body>
</html>

_______________________________________________
drbd-dev mailing list
drbd-dev@lists.linbit.com
https://lists.linbit.com/mailman/listinfo/drbd-dev

--===============6380031738630904480==--

[prev in list] [next in list] [prev in thread] [next in thread] 