[prev in list] [next in list] [prev in thread] [next in thread] 

List:       drbd-cvs
Subject:    [DRBD-cvs] svn commit by lars - r3063 - branches/drbd-8.0/user -
From:       drbd-cvs () linbit ! com
Date:       2007-09-19 15:48:48
Message-ID: 20070919154848.5E7DC4009A () garcon1 ! linbit ! com
[Download RAW message or body]

Author: lars
Date: 2007-09-19 17:48:47 +0200 (Wed, 19 Sep 2007)
New Revision: 3063

Modified:
   branches/drbd-8.0/user/drbdadm_main.c
Log:
would you please initialize an array before iterating over it?

Modified: branches/drbd-8.0/user/drbdadm_main.c
===================================================================
--- branches/drbd-8.0/user/drbdadm_main.c	2007-09-17 09:15:41 UTC (rev 3062)
+++ branches/drbd-8.0/user/drbdadm_main.c	2007-09-19 15:48:47 UTC (rev 3063)
@@ -1222,6 +1222,9 @@
   sigaction(SIGCHLD,&sa,&so);
 
   pids = alloca( nr_resources * sizeof(pid_t) );
+  /* alloca can not fail, it can "only" overflow the stack :)
+   * but it needs to be initialized anyways! */
+  memset(pids,0,nr_resources * sizeof(pid_t));
 
   for_each_resource(res,t,config) {
     argc=0;

_______________________________________________
drbd-cvs mailing list
drbd-cvs@lists.linbit.com
http://lists.linbit.com/mailman/listinfo/drbd-cvs
[prev in list] [next in list] [prev in thread] [next in thread]