[prev in list] [next in list] [prev in thread] [next in thread] 

List:       dpdk-dev
Subject:    Re: [PATCH v3 0/3] Release ethdev shared memory on port cleanup
From:       Thomas Monjalon <thomas () monjalon ! net>
Date:       2023-08-31 16:05:11
Message-ID: 3559497.LM0AJKV5NW () thomas
[Download RAW message or body]

21/08/2023 10:58, David Marchand:
> This series was triggered after investigating why the
> eal_flags_file_prefix_autotest unit test was failing in the case of
> statically built binaries [1]).
> 
> For now, I went with a simple (naive) approach and put all accesses to the
> shared data under a single lock: ethdev maintainers, it is your turn to
> shine and give me reasons why we should keep the locks the way they
> were ;-).

I think the reasons are:
- we wanted to call rte_spinlock_init()
- we didn't want to allocate an ethdev lock in EAL memory config

How eliminating a lock is making the last patch easier exactly?


[prev in list] [next in list] [prev in thread] [next in thread]