[prev in list] [next in list] [prev in thread] [next in thread] 

List:       dpdk-dev
Subject:    Re: [dpdk-dev] [PATCH 0/5] blank lines at EOF fixes
From:       Bruce Richardson <bruce.richardson () intel ! com>
Date:       2019-07-31 15:38:41
Message-ID: 20190731153841.GH1705 () bricha3-MOBL ! ger ! corp ! intel ! com
[Download RAW message or body]

On Wed, Jul 31, 2019 at 07:57:37AM -0700, Stephen Hemminger wrote:
> Using a simple shell script which cleans up trailing whitespace
> found several places with extra lines at end of file.
> 
> More in base drivers but they are known to be problematic.
> 
> Stephen Hemminger (5):
>   examples: remove extra blank lines at eof
>   test: remove blank lines at eof
>   pmdinfogen: remove blank line at eof
>   net/ipn3ke: cleanup blank line at eof
>   net/mlx5: remove blank lines at eof
> 
>  app/test/test_cryptodev_asym_util.h   | 4 ----
>  app/test/test_table_combined.c        | 1 -
>  app/test/test_table_tables.c          | 3 +--
>  buildtools/pmdinfogen/pmdinfogen.h    | 1 -
>  drivers/net/ipn3ke/ipn3ke_flow.c      | 1 -
>  drivers/net/ipn3ke/ipn3ke_tm.c        | 1 -
>  drivers/net/mlx5/mlx5_rxtx.c          | 2 --
>  examples/flow_filtering/flow_blocks.c | 1 -
>  examples/l3fwd-power/perf_core.c      | 1 -
>  examples/vhost_scsi/vhost_scsi.c      | 1 -
>  10 files changed, 1 insertion(+), 15 deletions(-)
> 
Series-acked-by: Bruce Richardson <bruce.richardson@intel.com>

I really wonder if removing blank lines at EOF would really be a problem
for base drivers? Seems like it should not be a major issue, but perhaps
maintainers best comment first.
[prev in list] [next in list] [prev in thread] [next in thread]