[prev in list] [next in list] [prev in thread] [next in thread] 

List:       dovecot-cvs
Subject:    dovecot-2.2-pigeonhole: lda-sieve plugin: Don't access already f...
From:       pigeonhole () rename-it ! nl (pigeonhole at rename-it ! nl)
Date:       2013-08-15 19:08:47
Message-ID: hg.0e7b22c65147.1376593727.343897724 () sinalco ! rename-it ! nl
[Download RAW message or body]

details:   http://hg.rename-it.nl/dovecot-2.2-pigeonhole/rev/0e7b22c65147
changeset: 1790:0e7b22c65147
user:      Stephan Bosch <stephan at rename-it.nl>
date:      Thu Aug 15 20:15:08 2013 +0200
description:
lda-sieve plugin: Don't access already freed memory when deinitializing.
Patch by Timo Sirainen (modified).

diffstat:

 src/plugins/lda-sieve/lda-sieve-plugin.c |  5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diffs (19 lines):

diff -r 2452dae5792f -r 0e7b22c65147 src/plugins/lda-sieve/lda-sieve-plugin.c
--- a/src/plugins/lda-sieve/lda-sieve-plugin.c	Thu Aug 15 19:59:18 2013 +0200
+++ b/src/plugins/lda-sieve/lda-sieve-plugin.c	Thu Aug 15 20:15:08 2013 +0200
@@ -935,12 +935,13 @@
 			ret = -1;
 		else
 			ret = lda_sieve_execute(&srctx, storage_r);
+	
+		for ( i = 0; i < srctx.script_count; i++ )
+			sieve_script_unref(&srctx.scripts[i]);
 	} T_END;
 
 	/* Clean up */
 
-	for ( i = 0; i < srctx.script_count; i++ )
-		sieve_script_unref(&srctx.scripts[i]);
 	if ( srctx.user_ehandler != NULL )
 		sieve_error_handler_unref(&srctx.user_ehandler);
 	sieve_error_handler_unref(&srctx.master_ehandler);

[prev in list] [next in list] [prev in thread] [next in thread]