[prev in list] [next in list] [prev in thread] [next in thread] 

List:       dovecot
Subject:    Re: [Dovecot] beta5 builds under RHEL
From:       Axel Thimm <Axel.Thimm () ATrpms ! net>
Date:       2010-05-31 4:18:05
Message-ID: 20100531041805.GA4281 () victor ! nirvana
[Download RAW message or body]


Hi,

On Sun, May 30, 2010 at 08:02:03PM -0700, Brandon Davidson wrote:
> On 5/30/10 2:49 PM, "Axel Thimm" <Axel.Thimm@ATrpms.net> wrote:
> > How are your %optflags (which is the same as $RPM_OPT_FLAGS) merged
> > into the build [...]
> 
> They're exported by the %configure macro, and configure writes the
> combined CFLAGS, CXXFLAGS, and FFLAGS into the Makefile... so it's
> not necessary (and possibly detrimental) to both export them before
> configuring and pass them explicitly to make, as the command-line
> CLFAGS option overrides the Makefile CFLAGS declaration that
> includes -std=gnu99.

True, I wasn't wearing my brain in the last post ;)
Indeed, both configure and make were getting the same CFLAGS, and
while configure was properly altering it, the make invocation was
resetting it again. :/

More interesting is the fact that I introduced the bug with the
dovecot-2.x specfile, so the 1.x builds were unaffected. I wonder how
this did sneak in.

> My point is, if I don't inclue CFLAGS="..." in my call to make in the spec
> file, it builds fine, and *does* include all the necessary optflags. Give it
> a try.

Doing so and RHEL5/x86_64 already built w/o an issue, I now quite
positive that the rest including RHEL4 will be as happy!

Thanks for finding the bug!
-- 
Axel.Thimm at ATrpms.net

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]