[prev in list] [next in list] [prev in thread] [next in thread] 

List:       dm-devel
Subject:    Re: [dm-devel] [PATCH 08/19] libmultipath: decrease log level of word splitting
From:       "Benjamin Marzinski" <bmarzins () redhat ! com>
Date:       2018-11-29 20:49:45
Message-ID: 20181129204944.GK5077 () octiron ! msp ! redhat ! com
[Download RAW message or body]

On Wed, Nov 21, 2018 at 11:18:28AM +0100, Martin Wilck wrote:
> This will make log level 4 actually usable.

condlog doesn't actually handle verbosity levels gerater than 4
correctly when logging to syslog (there is no loglevel 8).  I didn't
even realize that there were any condlog(5, ...) calls.  I am all for
using them to make log level 4 usable, but we should cap prio at 7 in
log_safe(), to make syslog happy (not that syslog is used much
anymore).

Otherwise, I'm fine with this

-Ben
 
> Signed-off-by: Martin Wilck <mwilck@suse.com>
> ---
>  libmultipath/util.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libmultipath/util.c b/libmultipath/util.c
> index 66c47611..b5d2e706 100644
> --- a/libmultipath/util.c
> +++ b/libmultipath/util.c
> @@ -104,7 +104,7 @@ get_word (char * sentence, char ** word)
>  	}
>  	strncpy(*word, sentence, len);
>  	strchop(*word);
> -	condlog(4, "*word = %s, len = %i", *word, len);
> +	condlog(5, "*word = %s, len = %i", *word, len);
>  
>  	if (*p == '\0')
>  		return 0;
> -- 
> 2.19.1

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
[prev in list] [next in list] [prev in thread] [next in thread]