[prev in list] [next in list] [prev in thread] [next in thread] 

List:       dm-devel
Subject:    Re: [dm-devel] [PATCH 1/2] libmultipath: cleanup pthread_cleanup_pop call
From:       Martin Wilck <mwilck () suse ! de>
Date:       2018-11-28 9:02:05
Message-ID: 4169de593d8e13c7415efd34b5a9ab576a4bc208.camel () suse ! de
[Download RAW message or body]

On Wed, 2018-11-28 at 00:13 -0600,  Benjamin Marzinski  wrote:
> pthread_cleanup_push() and pthread_cleanup_pop() must be called in
> the
> same lexical scope.  In uevent_listen(), the pthread_cleanup_pop()
> call
> to cleanup the udev monitor is called in a nested 'if' block, within
> the block where pthread_cleanup_push() is called.  Since this is a
> single-statement if block, it doesn't actually cause any problems,
> but
> it should be fixed anyways.
> 
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
Reviewed-by: Martin Wilck <mwilck@suse.com>


--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
[prev in list] [next in list] [prev in thread] [next in thread]