[prev in list] [next in list] [prev in thread] [next in thread] 

List:       dm-devel
Subject:    Re: [dm-devel] dm-verity: Fix biovecs hash calculation regression
From:       Mike Snitzer <snitzer () redhat ! com>
Date:       2014-04-14 21:11:20
Message-ID: 20140414211119.GA24873 () redhat ! com
[Download RAW message or body]

On Mon, Apr 14 2014 at  4:29pm -0400,
Mikulas Patocka <mpatocka@redhat.com> wrote:

> 
> 
> On Mon, 14 Apr 2014, Milan Broz wrote:
> 
> > The commit
> >   003b5c5719f159f4f4bf97511c4702a0638313dd
> >   block: Convert drivers to immutable biovecs
> > 
> > incorrectly converted biovec iteration in dm-verity to always
> > calculate hash from full biovec, while the function need
> > to calculate hash only from part of it (up to "todo"
> > calculated value).
> > 
> > This patch fixes the issue by limiting hash input to only
> > really requested data size.
> > 
> > The problem is easily reproducible using cryptsetup
> > regression test for veritysetup (verity-compat-test).
> > 
> > (Patch should be applied also to 3.14 stable.)
> > 
> > Signed-off-by: Milan Broz <gmazyland@gmail.com>
> 
> Acked-by: Mikulas Patocka <mpatocka@redhat.com>
> Cc: stable@vger.kernel.org	# 3.14

I'll pick this up to include in 3.15 fixes that I'll be sending to Linus.

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
[prev in list] [next in list] [prev in thread] [next in thread]