[prev in list] [next in list] [prev in thread] [next in thread] 

List:       dm-devel
Subject:    Re: [dm-devel] [PATCH 3/4] dm-userspace: fix DMU_FLAG_SYNC
From:       Dan Smith <danms () us ! ibm ! com>
Date:       2006-09-30 16:32:59
Message-ID: m3ejttz550.fsf () guaranine ! beaverton ! ibm ! com
[Download RAW message or body]

Content-Transfer-Encoding: quoted-printable

FT> My point is that the kernel module always sets DMU_FLAG_SYNC flag
FT> regardless of user space. As the patch does, should dmu_cpy_flag
FT> be used instead of cmu_set_flag? This enables a user-space
FT> programs to choose the behavior.

This is what I did previously; I let userspace set the sync flag if it
wanted to catch the endio.  However, during some debugging, I decided
to just send every endio to userspace.  I think I did this because I
was getting some corruption and thought it might be related to endio.
I think you are right, however, that because we can complete the IOs
in any order, we can delay some endios and not others.  I'll change it
back to copy the flag and do some more testing Monday to verify.

-- 
Dan Smith
IBM Linux Technology Center
Open Hypervisor Team
email: danms@us.ibm.com

[Attachment #3 (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]