[prev in list] [next in list] [prev in thread] [next in thread] 

List:       dm-crypt
Subject:    [dm-crypt] Exhaustive key reading seems to silently stop
From:       mbroz () redhat ! com (Milan Broz)
Date:       2009-12-11 11:59:07
Message-ID: 4B22340B.8060500 () redhat ! com
[Download RAW message or body]

On 12/11/2009 11:57 AM, Nico R. wrote:

>>> In lib/utils.c (line 450f. in cryptsetup-1.0.7; line 490f. in current
>>> SVN revision, r132, equal to r152), we see the following code:
>>>
>>> if(read(fd, pass + i, 1) != 1 || (newline_stop && pass[i] == '\n'))
>>>         break;
>>>
>>> If I interpret that snipped (and its surroundings) correctly, the code
>>> will read until EOF *or* until an error occurs.

yes, sure it is bug, thanks for reporting it.

Fixed in trunk now
http://code.google.com/p/cryptsetup/source/detail?r=154#

Milan
--
mbroz at redhat.com

[prev in list] [next in list] [prev in thread] [next in thread]