[prev in list] [next in list] [prev in thread] [next in thread] 

List:       dhcp-hackers
Subject:    Bug: Warnings seen compiling res_findzonecut.c in 4.1.1
From:       John Center <john.center () villanova ! edu>
Date:       2010-02-05 15:54:17
Message-ID: 4B6C3F29.4070305 () villanova ! edu
[Download RAW message or body]

Hi,

I'm seeing the following warnings in minires/res_findzonecut.c in 4.1.1, 
compiling 64bit on Solaris 10 (SPARC) using Sun Studio 12.1:

source='res_findzonecut.c' object='res_findzonecut.o' libtool=no \
DEPDIR=.deps depmode=none /bin/bash ../depcomp \
cc -DHAVE_CONFIG_H -I. -I. -I../includes  -DMINIRES_LIB -DHMAC_MD5 
-I/opt/gnu/include
-I/opt/local/include -I/usr/sfw/include -I/opt/openssl/include  -g -xs 
-fast -xtarget=
ultraT1 -xarch=sparcvis2 -m64 -mt -xipo -xcode=pic32 -xpagesize=default 
-xregs=no%appl
   -D_XOPEN_SOURCE -D_XOPEN_SOURCE_EXTENDED=1 -D__EXTENSIONS__  -c 
res_findzonecut.c
"res_findzonecut.c", line 162: warning: enum type mismatch: op "="
"res_findzonecut.c", line 168: warning: enum type mismatch: op "="
"res_findzonecut.c", line 263: warning: enum type mismatch: op "="
"res_findzonecut.c", line 317: warning: enum type mismatch: op "="
"res_findzonecut.c", line 326: warning: enum type mismatch: op "="
"res_findzonecut.c", line 335: warning: enum type mismatch: op "="
"res_findzonecut.c", line 345: warning: enum type mismatch: op "="
"res_findzonecut.c", line 353: warning: enum type mismatch: op "="
"res_findzonecut.c", line 364: warning: enum type mismatch: op "="
"res_findzonecut.c", line 370: warning: enum type mismatch: op "="


* find_cached_zone() returns enum isc_result_t, but it is defined to 
return ns_rcode in includes/minires/minires.h:

includes/minires/minires.h
212c212
< ns_rcode find_cached_zone (const char *, ns_class, char *,
---
 > isc_result_t find_cached_zone (const char *, ns_class, char *,


* get_soa() is supposed to return enum ns_rcode in res_findzonecut.c, 
but it actually returns isc_result_t:

minires/res_findzonecut.c
70c70
< static ns_rcode       get_soa(res_state, const char *, ns_class,
---
 > static isc_result_t get_soa(res_state, const char *, ns_class,
243c243
< static ns_rcode
---
 > static isc_result_t
253,254c253
<       u_int rcode;
<       isc_result_t status;
---
 >       isc_result_t rcode;
261,263c260,262
<       status = ns_makecanon(dname, tname, sizeof tname);
<       if (status != ISC_R_SUCCESS)
<               return status;
---
 >       rcode = ns_makecanon(dname, tname, sizeof tname);
 >       if (rcode != ISC_R_SUCCESS)
 >               return rcode;


HTH

	-John


-- 
John Center
Villanova University
_______________________________________________
dhcp-hackers mailing list
dhcp-hackers@lists.isc.org
https://lists.isc.org/mailman/listinfo/dhcp-hackers
[prev in list] [next in list] [prev in thread] [next in thread]