[prev in list] [next in list] [prev in thread] [next in thread] 

List:       dhcp-client
Subject:    Need fix for the BUG
From:       Motomichi Matsuzaki <mzaki () e-mail ! ne ! jp>
Date:       2000-09-30 19:01:31
[Download RAW message or body]

   *** From dhcp-client -- To unsubscribe, see the end of this message. ***



> RFC2132 says:
> 
> 	Options containing NVT ASCII data SHOULD NOT include a trailing NULL;
> 	however, the receiver of such options MUST be prepared to delete
> 	trailing nulls if they exist.
> 
> 	(RFC2132 2. BOOTP Extension/DHCP Option Field Format)
> 
> isc-dhcp 2.0pl5 client seems to violate this.

This causes interoperability problem against Microsoft servers.

Microsoft DHCP servers always send with trailing NULL characters.

This must be fixed!!



> ad hoc patch is:
> 
> --- common/options.c	Sat Jun 24 16:24:02 2000
> +++ /home/mzaki/options.c	Mon Sep 11 23:08:56 2000
> @@ -551,6 +551,7 @@
>  				if (emit_quotes)
>  					*op++ = '"';
>  				for (; dp < data + len; dp++) {
> +					if (*dp == '\0') continue;
>  					if (!isascii (*dp) ||
>  					    !isprint (*dp)) {
>  						sprintf (op, "\\%03o",

This patch is too ad hoc.
Please review and fix appropriately.

-- 
Motomichi Matsuzaki <mzaki@e-mail.ne.jp> 
Dept. of Biological Sciences, Grad. School of Science, Univ. of Tokyo, Japan 

-----------------------------------------------------------------------
To unsubscribe from this list, visit http://www.isc.org/dhcp-lists.html
or send mail to dhcp-client-request@isc.org with the subject line of
'unsubscribe'.
-----------------------------------------------------------------------

[prev in list] [next in list] [prev in thread] [next in thread]