[prev in list] [next in list] [prev in thread] [next in thread] 

List:       dccp
Subject:    Re: [PATCH 1/5] dccp: Mechanism to resolve CCID dependencies
From:       David Miller <davem () davemloft ! net>
Date:       2008-11-20 9:03:21
Message-ID: 20081120.010321.191266507.davem () davemloft ! net
[Download RAW message or body]

From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Tue, 18 Nov 2008 06:03:47 +0100

> | > +	list_for_each_entry(entry, fn_list, node)
> | > +		if (entry->feat_num == feat_num && entry->is_local == is_local)
> | > +			return entry;
> | > +		else if (entry->feat_num > feat_num)
> | > +			break;
> | 
> | Personally, I would have put braces around this basic block.
> | 
> If it is possible to modify without disturbance, I attach a patch for this and
> have changed it in the test tree.
> 
> I have checked that making this change does not affect subsequent
> patches - it works with either variant.

Applied, thanks Gerrit.  Please give a signoff next time.
--
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]