[prev in list] [next in list] [prev in thread] [next in thread] 

List:       dccp
Subject:    Re: [PATCH 5/7] [CCID-3]: Remove ugly RTT-sampling history lookup
From:       David Miller <davem () davemloft ! net>
Date:       2008-05-27 13:36:51
Message-ID: 20080527.063651.236273094.davem () davemloft ! net
[Download RAW message or body]

From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Tue, 27 May 2008 09:32:45 +0100

> This removes the RTT-sampling function tfrc_tx_hist_rtt(), since
> 
>  1. it suffered from complex passing of return values (the return value both
>     indicated successful lookup while the value doubled as RTT sample);
> 
>  2. when for some odd reason the sample value equalled 0, this triggered a bug
>     warning about "bogus Ack", due to the ambiguity of the return value;
> 
>  3. on a passive host which has not sent anything the TX history is empty and
>     thus will lead to unwanted "bogus Ack" warnings such as
>     ccid3_hc_tx_packet_recv: server(e7b7d518): DATAACK with bogus ACK-28197148
>     ccid3_hc_tx_packet_recv: server(e7b7d518): DATAACK with bogus ACK-26641606.
> 
> The fix is to replace the implicit encoding by performing the steps manually.
> 
> Furthermore, the "bogus Ack" warning has been removed, since it can actually be
> triggered due to several reasons (network reordering, old packet, (3) above),
> hence it is not very useful.
> 
> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>

This mixes bug fixes with cleanups, and also conflicts because I'm
not applying the hctx prefix changes.

Look, if you want to make the member names shorter, shorten the post-
prefix part of the name, instead of getting rid of the useful prefix
part.
--
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]