[prev in list] [next in list] [prev in thread] [next in thread] 

List:       dccp
Subject:    Re: [PATCH 3/7] [CCID-3]: Remove ccid3hc{tx,rx}_ prefixes
From:       David Miller <davem () davemloft ! net>
Date:       2008-05-27 13:26:12
Message-ID: 20080527.062612.59188315.davem () davemloft ! net
[Download RAW message or body]

From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Tue, 27 May 2008 09:32:43 +0100

> This patch does the same for CCID-3 as the previous patch for CCID-2:
> 
>         s#ccid3hctx_##g;
>         s#ccid3hcrx_##g;
> 
> plus manual editing to retain consistency.
> 
> Please note: expanded the fields of the `struct tfrc_tx_info' in the hc_tx_sock,
> since using short #define identifiers is not a good idea. The only place where
> this embedded struct was used is ccid3_hc_tx_getsockopt().
> 
> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>

My same comments for CCID-2 apply here, don't do this, we use
the member name prefixes to make the code easier to search
precisely.
--
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]