[prev in list] [next in list] [prev in thread] [next in thread] 

List:       darcs-users
Subject:    Re: [darcs-users] Doubts about commuteFilepatches
From:       Iago Abal <iago.abal () gmail ! com>
Date:       2010-12-07 18:06:06
Message-ID: AANLkTine2Dq-pF1JmNMquG0ELHBM-P1Trt30_ExO5QJ3 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Today I comment out that two cases and I run "darcs-test --unit=yes" without
any failing test.
Maybe that's interesting (or maybe not).

On Tue, Nov 23, 2010 at 5:12 PM, Iago Abal <iago.abal@gmail.com> wrote:

> Yes, I'm talking about this two cases.
>
>
> On Tue, Nov 23, 2010 at 5:02 PM, Ian Lynagh <igloo@earth.li> wrote:
>
>> On Tue, Nov 23, 2010 at 01:25:01PM +0000, Iago Abal wrote:
>> >
>> > What commuteFP does is just trivially commute any id-hunk (stupid-hunk
>> does
>> > not seem a good name, since they make sense), and this is definetly
>> wrong
>> > (at least in theory, since effect-preserving is no longer true). So you
>> was
>> > right Eric, Darcs could end up trying to apply a Hunk f 20 [] [] when f
>> has
>> > 10 lines.
>>
>> You're talking about these, right?:
>>
>> commuteFP f (Hunk line1 [] [] :< p2) =
>>    seq f $ Succeeded (FP f (unsafeCoerceP p2) :< FP f (Hunk line1 [] []))
>> commuteFP f (p2 :< Hunk line1 [] []) =
>>    seq f $ Succeeded (FP f (Hunk line1 [] []) :< FP f (unsafeCoerceP p2))
>>
>> These look wrong to me too. If nothing else, I'd expect them to update
>> the line numbers in the Hunk/Hunk case.
>>
>>
>> Thanks
>> Ian
>>
>> _______________________________________________
>> darcs-users mailing list
>> darcs-users@darcs.net
>> http://lists.osuosl.org/mailman/listinfo/darcs-users
>>
>
>
>
> --
> Iago Abal Rivas
>



-- 
Iago Abal Rivas

[Attachment #5 (text/html)]

Today I comment out that two cases and I run &quot;darcs-test --unit=yes&quot; \
without any failing test.<div>Maybe that&#39;s interesting (or maybe \
not).<br><br><div class="gmail_quote">On Tue, Nov 23, 2010 at 5:12 PM, Iago Abal \
<span dir="ltr">&lt;<a \
href="mailto:iago.abal@gmail.com">iago.abal@gmail.com</a>&gt;</span> wrote:<br> \
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex;">Yes, I&#39;m talking about this two \
cases.<div><div></div><div class="h5"><br><br><div class="gmail_quote">On Tue, Nov \
23, 2010 at 5:02 PM, Ian Lynagh <span dir="ltr">&lt;<a href="mailto:igloo@earth.li" \
target="_blank">igloo@earth.li</a>&gt;</span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> <div>On Tue, Nov 23, 2010 at 01:25:01PM +0000, Iago Abal \
wrote:<br> &gt;<br>
&gt; What commuteFP does is just trivially commute any id-hunk (stupid-hunk does<br>
&gt; not seem a good name, since they make sense), and this is definetly wrong<br>
&gt; (at least in theory, since effect-preserving is no longer true). So you was<br>
&gt; right Eric, Darcs could end up trying to apply a Hunk f 20 [] [] when f has<br>
&gt; 10 lines.<br>
<br>
</div>You&#39;re talking about these, right?:<br>
<div><br>
commuteFP f (Hunk line1 [] [] :&lt; p2) =<br>
    seq f $ Succeeded (FP f (unsafeCoerceP p2) :&lt; FP f (Hunk line1 [] []))<br>
commuteFP f (p2 :&lt; Hunk line1 [] []) =<br>
    seq f $ Succeeded (FP f (Hunk line1 [] []) :&lt; FP f (unsafeCoerceP p2))<br>
<br>
</div>These look wrong to me too. If nothing else, I&#39;d expect them to update<br>
the line numbers in the Hunk/Hunk case.<br>
<br>
<br>
Thanks<br>
Ian<br>
<br>
_______________________________________________<br>
darcs-users mailing list<br>
<a href="mailto:darcs-users@darcs.net" target="_blank">darcs-users@darcs.net</a><br>
<a href="http://lists.osuosl.org/mailman/listinfo/darcs-users" \
target="_blank">http://lists.osuosl.org/mailman/listinfo/darcs-users</a><br> \
</blockquote></div><br><br clear="all"><br></div></div><font color="#888888">-- \
<br>Iago Abal Rivas<br> </font></blockquote></div><br><br clear="all"><br>-- <br>Iago \
Abal Rivas<br> </div>



_______________________________________________
darcs-users mailing list
darcs-users@darcs.net
http://lists.osuosl.org/mailman/listinfo/darcs-users


[prev in list] [next in list] [prev in thread] [next in thread]