[prev in list] [next in list] [prev in thread] [next in thread] 

List:       darcs-devel
Subject:    Re: [darcs-devel] [patch2022] harnes, tests: import lib in all test scr... (and 7 more)
From:       Ben Franksen <ben.franksen () online ! de>
Date:       2020-05-21 6:02:37
Message-ID: ra55ht$ufr$1 () ciao ! gmane ! io
[Download RAW message or body]

Sorry, bundle not for screened. Forgot the -o option to send.

Am 21.05.20 um 07:39 schrieb Ben Franksen:
> 
> New submission from Ben Franksen <ben.franksen@online.de>:
> 
> 8 patches for repository http://darcs.net/screened:
> 
> patch 5b5dc69a13fde05309a5b57cd01b2e9b04f2df29
> Author: Ben Franksen <ben.franksen@online.de>
> Date:   Fri May  1 18:52:27 CEST 2020
> * harnes,tests: import lib in all test scripts, no longer set env in Haskell
> 
> This slightly simplifies the environment handling logic in the harness.
> 
> patch 02e55fa4bfb0f785f7c24efe7a4257d70c3cea97
> Author: Ben Franksen <ben.franksen@online.de>
> Date:   Fri May  1 14:26:45 CEST 2020
> * harness: use PatchFormat and DiffAlgorithm from Darcs.Repository.Flags
> 
> patch b2d0d11007ec22e816bbe14641076091aa2e9474
> Author: Ben Franksen <ben.franksen@online.de>
> Date:   Fri May  1 16:48:03 CEST 2020
> * harness: use RecordWildCards in test.hs
> 
> patch a0528921a72d3130c70f791bd1d0b1414a77bbf0
> Author: Ben Franksen <ben.franksen@online.de>
> Date:   Fri May  1 21:10:30 CEST 2020
> * harness: further simplify environment logic for PATH
> 
> Instead of splitting and reconstructing the PATH variable, just prepend the
> directory of the darcs under test directly in the env file.
> 
> patch 9265001d8f5c159b4bab4f0b1ec574754bfe01a0
> Author: Ben Franksen <ben.franksen@online.de>
> Date:   Fri May  1 14:15:11 CEST 2020
> * harness: use turtle to find the darcs executable to test
> 
> This is a first step toward refactoring harness/test.hs to get rid of the
> shelly dependency.
> 
> patch d101ae051e27711bb7747c225c1a1cdedd7baecd
> Author: Ben Franksen <ben.franksen@online.de>
> Date:   Sat May  2 01:06:10 CEST 2020
> * replace dependency on shelly with turtle
> 
> This has been more difficult than I expected. There are two points where
> turtle is weaker than shelly: first, the 'cd' and 'setenv' commands are not
> thread-safe, whereas in shelly they are; second, in turtle (as in the
> standard System.Process) there is no way to intercept the handles that are
> created when we specify that they should be captured using pipes. Again,
> shelly offers this as a feature.
> 
> The solution for the first problem is to not set the environment and to not
> use 'cd'. Instead we pass the working directory directly to the process that
> runs the shell script. The second problem is solved using some low-level
> primitives from System.Process.
> 
> patch c2d14c7244167c74df50693b6f1e40585fb3e7f7
> Author: Ben Franksen <ben.franksen@online.de>
> Date:   Wed May 20 11:40:06 CEST 2020
> * TEST PATCH
> 
> patch c3683698198bf0728a8b11e42b62eb68e21eff69
> Author: Ben Franksen <ben.franksen@online.de>
> Date:   Wed May 20 11:40:06 CEST 2020
> * TEST PATCH2
> 
> ----------
> files: harnes_tests_-import-lib-in-all-test-scripts_-no-longer-set-env-in-haskell_0.dpatch, \
>                 patch-preview.txt, unnamed
> messages: 22025
> nosy: bf
> status: needs-screening
> title: harnes, tests: import lib in all test scr... (and 7 more)
> 
> __________________________________
> Darcs bug tracker <bugs@darcs.net>
> <http://bugs.darcs.net/patch2022>
> __________________________________
> 
> 
> _______________________________________________
> darcs-devel mailing list
> darcs-devel@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/darcs-devel
> 


_______________________________________________
darcs-devel mailing list
darcs-devel@osuosl.org
https://lists.osuosl.org/mailman/listinfo/darcs-devel


[prev in list] [next in list] [prev in thread] [next in thread]