[prev in list] [next in list] [prev in thread] [next in thread] 

List:       darcs-devel
Subject:    [darcs-devel] [patch1052] Mark issue1105 as failing again (and 1 more)
From:       Ganesh Sittampalam <bugs () darcs ! net>
Date:       2013-03-18 21:26:03
Message-ID: E1UHhYy-0006T0-9o () urchin ! earth ! li
[Download RAW message or body]

Ganesh Sittampalam <ganesh@earth.li> added the comment:

1 patch for repository darcs-unstable@darcs.net:screened:

Mon Mar 18 18:07:44 GMT 2013  Ganesh Sittampalam <ganesh@earth.li>
  * fix warnings introduced by issue1105 fix

__________________________________
Darcs bug tracker <bugs@darcs.net>
<http://bugs.darcs.net/patch1052>
__________________________________
["patch-preview.txt" (text/x-darcs-patch)]


[fix warnings introduced by issue1105 fix
Ganesh Sittampalam <ganesh@earth.li>**20130318180744
 Ignore-this: 94b277843eab878ec89424850491ac69
] hunk ./src/Darcs/UI/ArgumentDefaults.hs 19
 --  Boston, MA 02110-1301, USA.
 
 module Darcs.UI.ArgumentDefaults ( getDefaultFlags ) where
-import Data.Maybe ( listToMaybe, mapMaybe )
+import Data.Maybe ( mapMaybe )
 
 import Darcs.UI.Arguments ( DarcsFlag,
                          atomicOptions, DarcsAtomicOption( .. ), DarcsOption ( .. ),
hunk ./src/Darcs/UI/ArgumentDefaults.hs 61
 findOption opts all_opts already (c, f, d) =
     if all (== NotFound) $ map choose_option all_opts
     then error $ "Bad default option: command '"++c++"' has no option '"++f++"'."
-    else [f | Found f <- map choose_option opts]
+    else [found | Found found <- map choose_option opts]
     where choose_atomic_option :: DarcsAtomicOption -> Maybe DarcsFlag
           choose_atomic_option (DarcsNoArgOption _ fls o _)
               | f `elem` fls = if null d
hunk ./src/Darcs/UI/ArgumentDefaults.hs 82
               | o `arein` already =
                 case mapMaybe choose_atomic_option $ atomicOptions o of
                   [] -> NotFound
-                  a:_ -> Superseded
+                  _:_ -> Superseded
               | otherwise = case mapMaybe choose_atomic_option $ atomicOptions o of
                   [] -> NotFound
                   a:_ -> Found a


["fix-warnings-introduced-by-issue1105-fix.dpatch" (application/x-darcs-patch)]
["unnamed" (application/octet-stream)]

_______________________________________________
darcs-devel mailing list
darcs-devel@darcs.net
http://lists.osuosl.org/mailman/listinfo/darcs-devel


[prev in list] [next in list] [prev in thread] [next in thread]