[prev in list] [next in list] [prev in thread] [next in thread] 

List:       darcs-devel
Subject:    Re: [darcs-devel] darcs patch: Improved SSH ControlMaster check. (and
From:       "Eric Kow" <eric.kow () gmail ! com>
Date:       2006-07-13 23:54:42
Message-ID: 4a0b969d0607131654i463e96by9b2d212e8c6c1c2c () mail ! gmail ! com
[Download RAW message or body]

Hi Juliusz and list,

(Note: away from home till the 24th, so probably no in-depth thoughts
from me till then)

On 7/13/06, Juliusz Chroboczek <Juliusz.Chroboczek@pps.jussieu.fr> wrote:
> >   * Improved SSH ControlMaster check.
> Eric, this looks fragile to me.  Is there any way to avoid it?

I think so.  Let's reject this patch.

Maybe just having the Windows /dev/null stuff should do the trick, no
need to change the CM stuff.  We might need to rewrite the
do-not-output-to-dev-null patch though (so that it no longer depends
on previous patches).  Note that the latter patch is neccesary if we
apply the Windows /dev/null stuff; otherwise, putty users would not be
informed when they have to type a password.

That being said, I'm still dissatisfied with the current CM check and
would be delighted if somebody would suggest a better one.

-- 
Eric Kow                     http://www.loria.fr/~kow
PGP Key ID: 08AC04F9         Merci de corriger mon français.

_______________________________________________
darcs-devel mailing list
darcs-devel@darcs.net
http://www.abridgegame.org/cgi-bin/mailman/listinfo/darcs-devel

[prev in list] [next in list] [prev in thread] [next in thread]