[prev in list] [next in list] [prev in thread] [next in thread]
List: cyrus-devel
Subject: Re: [Cyrus-CVS] src/cyrus/lib by brong
From: Matt Selsky <selsky () columbia ! edu>
Date: 2009-05-07 1:03:01
Message-ID: C8BEFC8A-91C2-476F-9CA8-50D219E12CF6 () columbia ! edu
[Download RAW message or body]
In libcyr_cfg.h, the comment should say "ON" to match libcyr_cfg.c,
correct?
/* Checkpoint after every recovery (ON) */
CYRUSOPT_SKIPLIST_ALWAYS_CHECKPOINT,
On Mar 31, 2009, at 12:43 AM, brong@andrew.cmu.edu wrote:
> Update of /afs/andrew.cmu.edu/system/cvs/src/cyrus/lib
> In directory cyrus-devel-01.andrew.cmu.edu:/afs/andrew.cmu.edu/usr3/
> brong/src/cyrus/lib
>
> Modified Files:
> cyrusdb_skiplist.c imapoptions libcyr_cfg.c libcyr_cfg.h
> Log Message:
> skiplist always checkpoint
>
> Adds an option skiplist_always_checkpoint to force a checkpoint of
> every skiplist database every time recovery is run (generally the
> first
> time it gets accessed after a cyrus restart, or after any crash)
>
> The theory behind this is "repack it while it's hot" - recovery
> already
> accesses pretty much every page in the file, so the IO cost isn't too
> bad.
>
> ===================================================================
>
>
> --- links to diffs follow ---
> http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/lib/cyrusdb_skiplist.c.diff?r1=1.64&r2=1.65
> http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/lib/imapoptions.diff?r1=1.62&r2=1.63
> http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/lib/libcyr_cfg.c.diff?r1=1.16&r2=1.17
> http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/lib/libcyr_cfg.h.diff?r1=1.12&r2=1.13
>
[Attachment #3 (text/html)]
<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; \
-webkit-line-break: after-white-space; " class=""><pre class="" style=""><font \
class="Apple-style-span" face="Helvetica" size="3"><span class="Apple-style-span" \
style="font-size: 12px; white-space: normal;">In libcyr_cfg.h, the comment should say \
"ON" to match libcyr_cfg.c, correct?</span></font></pre><pre class="" style=""><font \
class="Apple-style-span" face="Helvetica" size="3"><span class="Apple-style-span" \
style="font-size: 12px; white-space: normal;"><br></span></font></pre><pre class="" \
style=""><font class="Apple-style-span" face="Helvetica" size="3"><span \
class="Apple-style-span" style="font-size: 12px; white-space: normal;">/* Checkpoint \
after every recovery (ON) */</span></font></pre><pre class="" style=""><font \
class="Apple-style-span" face="Helvetica" size="3"><span class="Apple-style-span" \
style="font-size: 12px; white-space: \
normal;">CYRUSOPT_SKIPLIST_ALWAYS_CHECKPOINT,</span></font> </pre><pre class="" \
style=""><font class="Apple-style-span" face="Helvetica" size="3"><span \
class="Apple-style-span" style="font-size: 12px; white-space: normal;"><br class="" \
style=""></span></font></pre><div class="" style=""><div class="" style="">On Mar 31, \
2009, at 12:43 AM, <a href="mailto:brong@andrew.cmu.edu">brong@andrew.cmu.edu</a> \
wrote:</div><br class="" style=""><blockquote type="cite"><div class="" \
style="">Update of /afs/andrew.cmu.edu/system/cvs/src/cyrus/lib<br class="" \
style="">In directory \
cyrus-devel-01.andrew.cmu.edu:/afs/andrew.cmu.edu/usr3/brong/src/cyrus/lib<br \
class="" style=""><br class="" style="">Modified Files:<br class="" style=""><span \
class="Apple-tab-span" style="white-space:pre"> </span>cyrusdb_skiplist.c imapoptions \
libcyr_cfg.c libcyr_cfg.h <br class="" style="">Log Message:<br class="" \
style="">skiplist always checkpoint<br class="" style=""><br class="" style="">Adds \
an option skiplist_always_checkpoint to force a checkpoint of<br class="" \
style="">every skiplist database every time recovery is run (generally the first<br \
class="" style="">time it gets accessed after a cyrus restart, or after any crash)<br \
class="" style=""><br class="" style="">The theory behind this is "repack it while \
it's hot" - recovery already<br class="" style="">accesses pretty much every page in \
the file, so the IO cost isn't too<br class="" style="">bad.<br class="" style=""><br \
class="" style="">===================================================================<br \
class="" style=""><br class="" style=""><br class="" style="">--- links to diffs \
follow ---<br class="" style=""><a \
href="http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/lib/cyrusdb_skiplist \
.c.diff?r1=1.64&r2=1.65">http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/lib/cyrusdb_skiplist.c.diff?r1=1.64&r2=1.65</a><br \
class="" style="">http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/lib/imapoptions.diff?r1=1.62&r2=1.63<br \
class="" style="">http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/lib/libcyr_cfg.c.diff?r1=1.16&r2=1.17<br \
class="" style="">http://bugzilla.andrew.cmu.edu/cgi-bin/cvsweb.cgi/src/cyrus/lib/libcyr_cfg.h.diff?r1=1.12&r2=1.13<br \
class="" style=""><br class="" style=""></div></blockquote></div><br class="" \
style=""></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic