[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cygwin-patches
Subject:    Re: [PATCH] Cygwin: cpuinfo: Linux 6.5: add AMD 0x8000001f EAX 14 debug_swap SEV-ES full debug state
From:       Brian Inglis <Brian.Inglis () Shaw ! ca>
Date:       2023-08-31 20:12:03
Message-ID: 87307c9a-38af-9b6c-0b0f-0acd8e74d93e () Shaw ! ca
[Download RAW message or body]

On 2023-08-31 03:08, Corinna Vinschen wrote:
> nothing against the patch as such, but your subject line is not so nice.
> As it becomes the commit message first line, it should be shorter. Add
> more descriptive text instead, please, and make sure that it tells the
> reader what you're really doing, i. e.:

Sorry - really jammed it up - only a single mod this release - normally would 
split into release and details - will redo and resubmit.

> You write "add <something>", but your patch is actually exchanging one
> <somthing> with another <something>.

Existing comments are for AMD SEV features originally defined, to be implemented 
and exposed in /proc/cpuinfo "soon" for use in KVM, Xen, and similar projects. 
But not as quickly as previously expected, with timing, speculative and 
transient execution, and side channel attacks, leaks, ucode and mitigation 
patches, not letting up - and now cpu bugs vector is an array! ;^>

> The reader of the commit message would probably like to know why you're
> doing that. Partially copying the original Linux kernel commit message
> should be ok.

Those are often more function specific and in patches to earlier releases e.g.

	KVM: SEV: Enable data breakpoints in SEV-ES
	...
	Make X86_FEATURE_DEBUG_SWAP appear in /proc/cpuinfo...

which then go through subsystem then kernel repo merges to finally hit

	arch/x86/include/asm/cpufeatures.h

and other feature code, where my weekly selective cpuid-related kernel 
downloads, run cpu features cpuinfo display names array gen Linux script, and 
diff features defined and displayed.

Also Intel now hides new features in MSRs, so these become Linux software 
defined features, which we can not display if visible in /proc/cpuinfo, as we 
seem to have no view of MSRs from Windows user space (no MSR driver).

> Also, given that changes a string, does it qualify for a "Fixes:" tag?

Sometimes another vendor or arch announces a similar feature, not always using 
the same terminology, cpuids, or bits, so common Linux terminology replaces 
vendor or arch feature names, for display, as in this case.

> On Aug 30 22:10, Brian Inglis wrote:
>> Signed-off-by: Brian Inglis 
>> ---
>>   winsup/cygwin/fhandler/proc.cc | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/winsup/cygwin/fhandler/proc.cc b/winsup/cygwin/fhandler/proc.cc
>> index cbc49a12a417..be107cb8eacc 100644
>> --- a/winsup/cygwin/fhandler/proc.cc
>> +++ b/winsup/cygwin/fhandler/proc.cc
>> @@ -1652,7 +1652,7 @@ format_proc_cpuinfo (void *, char *&destbuf)
>>   /*	  ftcprint (features2, 11, "sev_64b");*//* SEV 64 bit host guest only */
>>   /*	  ftcprint (features2, 12, "sev_rest_inj");   *//* SEV restricted injection */
>>   /*	  ftcprint (features2, 13, "sev_alt_inj");    *//* SEV alternate injection */
>> -/*	  ftcprint (features2, 14, "sev_es_dbg_swap");*//* SEV-ES debug state swap */
>> +	  ftcprint (features2, 14, "debug_swap");   /* SEV-ES full debug state swap */
>>   /*	  ftcprint (features2, 15, "no_host_ibs");    *//* host IBS unsupported */
>>   /*	  ftcprint (features2, 16, "vte");    *//* virtual transparent encryption */
>>   	}
>> -- 
>> 2.39.0

-- 
Take care. Thanks, Brian Inglis              Calgary, Alberta, Canada

La perfection est atteinte                   Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter  not when there is no more to add
mais lorsqu'il n'y a plus rien à retirer     but when there is no more to cut
                                 -- Antoine de Saint-Exupéry

[prev in list] [next in list] [prev in thread] [next in thread]