[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cygwin-patches
Subject:    Re: [PATCH v4 3/3] Respect `db_home: env` even when no uid can be determined
From:       Corinna Vinschen <corinna-cygwin () cygwin ! com>
Date:       2023-03-28 10:17:35
Message-ID: ZCK+v7yBxRBft3UK () calimero ! vinschen ! de
[Download RAW message or body]

On Mar 28 10:17, Johannes Schindelin wrote:
> In particular when we cannot figure out a uid for the current user, we
> should still respect the `db_home: env` setting. Such a situation occurs
> for example when the domain returned by `LookupAccountSid()` is not our
> machine name and at the same time our machine is no domain member: In
> that case, we have nobody to ask for the POSIX offset necessary to come
> up with the uid.
> 
> It is important that even in such cases, the `HOME` environment variable
> can be used to override the home directory, e.g. when Git for Windows is
> used by an account that was generated on the fly, e.g. for transient use
> in a cloud scenario.

How does this kind of account look like?  I'd like to see the contants
of name, domain, and the SID.  Isn't that just an account closely
resembling Micorosft Accounts or AzureAD accounts?  Can't we somehow
handle them alike?

> Reported by David Ebbo.

This should be

  Reported-By: David Ebbo <email address>

> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
>  winsup/cygwin/uinfo.cc | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/winsup/cygwin/uinfo.cc b/winsup/cygwin/uinfo.cc
> index d493d29b3b..b01bcff5cb 100644
> --- a/winsup/cygwin/uinfo.cc
> +++ b/winsup/cygwin/uinfo.cc
> @@ -883,6 +883,8 @@ fetch_from_path (cyg_ldap *pldap, PUSER_INFO_3 ui, cygpsid &sid, PCWSTR str,
>  	    case L'u':
>  	      if (full_qualified)
>  		{
> +		  if (!dom)
> +		    break;

No domain?  Really?


Corinna
[prev in list] [next in list] [prev in thread] [next in thread]