[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cygwin-patches
Subject:    Re: [PATCH 1/3] Cygwin: dll_list: drop FILE_BASIC_INFORMATION
From:       Corinna Vinschen <corinna-cygwin () cygwin ! com>
Date:       2019-04-30 16:38:13
Message-ID: 20190430163813.GU3383 () calimero ! vinschen ! de
[Download RAW message or body]


On Apr 30 18:13, Corinna Vinschen wrote:
> On Apr 30 16:14, Michael Haubenwallner wrote:
> > Querying FILE_BASIC_INFORMATION is needless since using win pid+threadid
> > for forkables dirname rather than newest last write time.
> > ---
> >  winsup/cygwin/dll_init.cc | 1 -
> >  winsup/cygwin/dll_init.h  | 1 -
> >  winsup/cygwin/forkable.cc | 7 +++----
> >  3 files changed, 3 insertions(+), 6 deletions(-)
> > [...]
> > -  if (!dll_list::read_fii (fhandle, &d->fii) ||
> > -      !dll_list::read_fbi (fhandle, &d->fbi))
> 
> Given this is the only place calling dll_list::read_fbi, the method
> and declaration should be removed, too.
> 
> > +  if (!dll_list::read_fii (fhandle, &d->fii))
> >      system_printf ("WARNING: Unable to read real file attributes for %W",
> >  		   pmsi1->SectionFileName.Buffer);
> >  
> >    NtClose (fhandle);
> > -  return d->fbi.FileAttributes != INVALID_FILE_ATTRIBUTES;
> > +  return d->fii.IndexNumber.QuadPart != -1LL;
> >  }
> >  
> >  /* easy use of NtOpenFile */
> > -- 
> > 2.19.2

I pushed this patch series as is now, but I have two requests:

- Please send a followup patch to remove the unused method.

- When sending patchsets, would you mind to send them with cover letter
  per `git format-patch --cover-letter'?  It's not a hard requirement,
  but it makes discussing single patches vs. patchsets clearer.

Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Maintainer

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]