[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cygwin-patches
Subject:    Re: [Patch] Allow access to /proc/registry/HKEY_PERFORMANCE_DATA
From:       "Chris January" <chris () atomice ! net>
Date:       2008-12-19 15:27:32
Message-ID: 2ce9650b0812190727i5dcfcee9h3398b6140e475431 () mail ! gmail ! com
[Download RAW message or body]

On Fri, Dec 19, 2008 at 1:58 PM, Christian Franke  wrote:
>        (fhandler_registry::fill_filebuf): Use larger buffer to speed up
>        access to HKEY_PERFORMANCE_DATA values.  Remove check for possible
>        subkey.  Add RegCloseKey ().

+      /* RegQueryValueEx () opens HKEY_PERFORMANCE_DATA.  */
+      RegCloseKey (handle);

I'm slightly puzzled by this change. handle is usually closed in
fhandler_register::close. If you close it here then won't CloseHandle
be called with an invalid handle in that method?

Chris
[prev in list] [next in list] [prev in thread] [next in thread]