[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cygwin-patches
Subject:    Re: [Patch] bug # 514 (cygwin console handling) - update
From:       Corinna Vinschen <vinschen () redhat ! com>
Date:       2004-12-16 13:23:02
Message-ID: 20041216132302.GA13898 () cygbert ! vinschen ! de
[Download RAW message or body]

On Dec 14 06:02, Thomas Wolff wrote:
> This is an update of my "trivial patch" that fixes
>  http://sourceware.org/bugzilla/show_bug.cgi?id=514
> 
> > I guess the patch is pretty much ok and I'm inclined to let it pass
> > under the trivial patch rule... iff you change it so that the #ifdef
> > goes away.  Which alternative seems more appropriate resp. which one
> > results in the more readable output?  It's the one we should choose
> > (since any choice will result in complains anyway).
> OK, I kept the alternative that was selected by #ifdef before. 
> It's the more consistent one anyway.
> 
> > And please shorten the ChangeLog entry to about one sentence.
> OK.

Well done, just the layout of the ChangeLog needed some reworking
(the whole entry should be tabbified).


Thanks for the patch,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          mailto:cygwin@cygwin.com
Red Hat, Inc.
[prev in list] [next in list] [prev in thread] [next in thread]