[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cygwin-patches
Subject:    Re: change log fix: [Patch] bug # 514 (cygwin console handling)
From:       Corinna Vinschen <vinschen () redhat ! com>
Date:       2004-12-14 12:04:35
Message-ID: 20041214120435.GI22056 () cygbert ! vinschen ! de
[Download RAW message or body]

On Dec  1 08:16, Thomas Wolff wrote:
> Sorry, I missed to insert the function name in the change log 
> entry, so here it is again as an update; the patch is the same.
> 
> This is a small patch that fixes
>  http://sourceware.org/bugzilla/show_bug.cgi?id=514
> 
> Please integrate it into the cygwin DLL.

I guess the patch is pretty much ok and I'm inclined to let it pass
under the trivial patch rule... iff you change it so that the #ifdef
goes away.  Which alternative seems more appropriate resp. which one
results in the more readable output?  It's the one we should choose
(since any choice will result in complains anyway).

> 2004-11-26  Thomas Wolff  <towo@computer.org>
> 
> * fhandler_console.cc (get_win32_attr): Avoid inappropriate intensity 
>      interchanging that used to render reverse output unreadable 
>      when (non-reversed) text is bright.
>      See http://sourceware.org/bugzilla/show_bug.cgi?id=514
>      There are two useful alternatives to handle this; both are in 
>      the patch (#ifdef reverse_bright) and one is selected by #define:
>      a) (selected) bright foreground will reverse to a bright background,
>      b) bright foreground will reverse to a dim background but 
>         the background will no longer reverse to a bright foreground 
>         (which used to render reverse output unreadable).

And please shorten the ChangeLog entry to about one sentence.


Thanks,
Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          mailto:cygwin@cygwin.com
Red Hat, Inc.
[prev in list] [next in list] [prev in thread] [next in thread]